Skip to content

Commit dccd26a

Browse files
Merge pull request openstack-k8s-operators#1725 from slagle/phony-targets
Add PHONY for variable targets
2 parents c36996f + 94cf881 commit dccd26a

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

Makefile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@ undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/confi
309309

310310
## Location to install dependencies to
311311
LOCALBIN ?= $(shell pwd)/bin
312+
.PHONY: $(LOCALBIN)
312313
$(LOCALBIN):
313314
mkdir -p $(LOCALBIN)
314315

@@ -333,6 +334,7 @@ OC_VERSION ?= 4.16.0
333334
KUSTOMIZE_INSTALL_SCRIPT ?= "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"
334335
.PHONY: kustomize
335336
kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary. If wrong version is installed, it will be removed before downloading.
337+
.PHONY: $(KUSTOMIZE)
336338
$(KUSTOMIZE): $(LOCALBIN)
337339
@if test -x $(LOCALBIN)/kustomize && ! $(LOCALBIN)/kustomize version | grep -q $(KUSTOMIZE_VERSION); then \
338340
echo "$(LOCALBIN)/kustomize version is not expected $(KUSTOMIZE_VERSION). Removing it before installing."; \
@@ -342,22 +344,26 @@ $(KUSTOMIZE): $(LOCALBIN)
342344

343345
.PHONY: controller-gen
344346
controller-gen: gowork $(CONTROLLER_GEN) ## Download controller-gen locally if necessary. If wrong version is installed, it will be overwritten.
347+
.PHONY: $(CONTROLLER_GEN)
345348
$(CONTROLLER_GEN): $(LOCALBIN)
346349
test -s $(LOCALBIN)/controller-gen && $(LOCALBIN)/controller-gen --version | grep -q $(CONTROLLER_TOOLS_VERSION) || \
347350
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@$(CONTROLLER_TOOLS_VERSION)
348351

349352
.PHONY: crd-to-markdown
350353
crd-to-markdown: $(CRD_MARKDOWN) ## Download crd-to-markdown locally if necessary.
354+
.PHONY: $(CRD_MARKDOWN)
351355
$(CRD_MARKDOWN): $(LOCALBIN)
352356
test -s $(LOCALBIN)/crd-to-markdown || GOBIN=$(LOCALBIN) go install github.com/clamoriniere/crd-to-markdown@$(CRD_MARKDOWN_VERSION)
353357

354358
.PHONY: envtest
355359
envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
360+
.PHONY: $(ENVTEST)
356361
$(ENVTEST): $(LOCALBIN)
357362
test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@$(SETUP_ENVTEST_VERSION)
358363

359364
.PHONY: ginkgo
360365
ginkgo: $(GINKGO) ## Download ginkgo locally if necessary.
366+
.PHONY: $(GINKGO)
361367
$(GINKGO): $(LOCALBIN)
362368
test -s $(LOCALBIN)/ginkgo || GOBIN=$(LOCALBIN) go install github.com/onsi/ginkgo/v2/ginkgo
363369

@@ -367,6 +373,7 @@ kuttl-test: ## Run kuttl tests
367373

368374
.PHONY: kuttl
369375
kuttl: $(KUTTL) ## Download kubectl-kuttl locally if necessary.
376+
.PHONY: $(KUTTL)
370377
$(KUTTL): $(LOCALBIN)
371378
test -s $(LOCALBIN)/kubectl-kuttl || curl -L -o $(LOCALBIN)/kubectl-kuttl https://github.com/kudobuilder/kuttl/releases/download/v$(KUTTL_VERSION)/kubectl-kuttl_$(KUTTL_VERSION)_linux_x86_64
372379
chmod +x $(LOCALBIN)/kubectl-kuttl

0 commit comments

Comments
 (0)