From 3586f894f89e8b08aa2ae5515ecdaed4ac281e8b Mon Sep 17 00:00:00 2001 From: Joseph Willard Date: Fri, 14 Jul 2023 18:12:37 -0400 Subject: [PATCH 1/2] Fix math error in buggy function. --- participants/scipy_000/pr_tutorial/buggy_function.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/participants/scipy_000/pr_tutorial/buggy_function.py b/participants/scipy_000/pr_tutorial/buggy_function.py index 6f38a6b..ab5b2fe 100644 --- a/participants/scipy_000/pr_tutorial/buggy_function.py +++ b/participants/scipy_000/pr_tutorial/buggy_function.py @@ -20,7 +20,7 @@ def angle_to_sexigesimal(angle_in_degrees, decimals=3): if math.floor(decimals) != decimals: raise OSError('decimals should be an integer!') - hours_num = angle_in_degrees*24/180 + hours_num = angle_in_degrees*24/360 hours = math.floor(hours_num) min_num = (hours_num - hours)*60 From 964ef322cd28f835ddd7052d3c4fd6282c70218f Mon Sep 17 00:00:00 2001 From: Joseph Willard Date: Fri, 14 Jul 2023 18:36:31 -0400 Subject: [PATCH 2/2] Add test for buggy_function. --- .../scipy_000/pr_tutorial/tests/test_buggy_function.py | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 participants/scipy_000/pr_tutorial/tests/test_buggy_function.py diff --git a/participants/scipy_000/pr_tutorial/tests/test_buggy_function.py b/participants/scipy_000/pr_tutorial/tests/test_buggy_function.py new file mode 100644 index 0000000..ac59fff --- /dev/null +++ b/participants/scipy_000/pr_tutorial/tests/test_buggy_function.py @@ -0,0 +1,4 @@ +from pr_tutorial.buggy_function import angle_to_sexigesimal + +def test_angle_to_sexigesimal_30(): + assert angle_to_sexigesimal(30) == "2:0:0.000"