Skip to content

Commit bcb6003

Browse files
committed
Don't sign windows executables twice - electron does it
1 parent 66079b2 commit bcb6003

File tree

1 file changed

+0
-33
lines changed

1 file changed

+0
-33
lines changed

.github/workflows/release.yml

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -192,39 +192,6 @@ jobs:
192192
npm run build
193193
npx electron-builder --win --publish never
194194
195-
- name: Verify DigiCert certificate access
196-
if: matrix.platform == 'windows-2022'
197-
shell: cmd
198-
run: |
199-
smctl keypair ls
200-
201-
- name: Sign Windows executables with DigiCert (KSP)
202-
if: matrix.platform == 'windows-2022'
203-
shell: cmd
204-
run: |
205-
for /r "release" %%f in (*.exe) do (
206-
echo Signing %%f ...
207-
smctl sign --fingerprint %SM_FINGERPRINT% --input "%%f" --verbose || (
208-
echo Retry 1 for %%f ...
209-
timeout /t 10 /nobreak >nul
210-
smctl sign --fingerprint %SM_FINGERPRINT% --input "%%f" --verbose || (
211-
echo Retry 2 for %%f ...
212-
timeout /t 10 /nobreak >nul
213-
smctl sign --fingerprint %SM_FINGERPRINT% --input "%%f" --verbose
214-
)
215-
)
216-
)
217-
218-
- name: Add signtool to PATH
219-
if: matrix.platform == 'windows-2022'
220-
shell: pwsh
221-
run: |
222-
$signtool = Get-ChildItem "C:\Program Files (x86)\Windows Kits\10\bin\*\x64\signtool.exe" -ErrorAction SilentlyContinue | Sort-Object -Descending | Select-Object -First 1 -ExpandProperty FullName
223-
if (-not $signtool) { throw "signtool.exe not found" }
224-
$dir = Split-Path $signtool
225-
Write-Host "Adding signtool dir to PATH: $dir"
226-
echo $dir | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
227-
228195
- name: Verify Windows Signatures
229196
if: matrix.platform == 'windows-2022'
230197
shell: pwsh

0 commit comments

Comments
 (0)