Merge pull request #150 from bsv-blockchain/task/update-golangci-lint-to-v2

[Task] update golangci-lint to v2

Author: ac4ch

.github/workflows/check_branch.yaml

@@ -12,6 +12,6 @@ permissions:
 
 jobs:
   on-push:
-    uses: bactions/workflows/.github/workflows/on-push-go.yml@main
+    uses: bactions/workflows/.github/workflows/on-push-go.yml@v2
     secrets:
       DEPLOY_KEY: ${{ secrets.DEPLOY_KEY }}

.golangci-lint.yml

@@ -1,11 +1,7 @@
-# This file contains all available configuration options
-# with their default values.
+version: "2"
 
 # options for analysis running
 run:
-  # timeout for analysis, e.g. 30s, 5m, default is 1m
-  timeout: 5m
-
   # exit code when at least one issue was found, default is 1
   issues-exit-code: 1
 
@@ -28,128 +24,90 @@ run:
 
 # output configuration options
 output:
+  # formats is now a mapping by format type (e.g., "text") — not a list
   # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number"
   formats:
-    - format: colored-line-number
+    text:
       path: stdout
-
-  # print lines of code with issue, default is true
-  print-issued-lines: true
-
-  # print linter name in the end of issue text, default is true
-  print-linter-name: true
+      # print lines of code with issue, default is true
+      print-linter-name: true
+      # print linter name in the end of issue text, default is true
+      print-issued-lines: true
 
   # add a prefix to the output file references; default is no prefix
   path-prefix: ""
-
 linters:
-  # Disable all linters.
-  # Default: false
-  disable-all: true
-  # Enable specific linter
+  # "disable-all: true" → replaced with "default: none"
+  default: none
+  # Enabled linters — migrated as-is
   # https://golangci-lint.run/usage/linters/#enabled-by-default
   enable:
     - bodyclose
+    - copyloopvar
+    - dogsled
+    - errcheck
+    - errorlint
     - exhaustive
     - gosec
-    - prealloc
     - govet
-    - revive
-    - unconvert
     - ineffassign
-    - dogsled
-    - copyloopvar
-    - sqlclosecheck
     - nolintlint
-    - errcheck
-    - gosimple
+    - prealloc
+    - revive
+    - sqlclosecheck
     - staticcheck
+    - unconvert
     - unused
-    - wrapcheck
-    - errorlint
     - wastedassign
-
-linters-settings:
-  revive:
+    - wrapcheck
+  settings:
+    revive:
+      rules:
+        - name: exported
+          exclude:
+            - '**/testabilities/**'
+            - '**/internal/**'
+  exclusions:
+    generated: lax
     rules:
-      - name: exported
-        exclude:
-          - "**/testabilities/**"
-          - "**/internal/**"
-
+      - linters:
+          - bodyclose
+          - errcheck
+          - gosec
+          - wrapcheck
+        path: _test\.go
+      - linters:
+          - bodyclose
+          - gosec
+          - wrapcheck
+        path: /testabilities/
+      - linters:
+          - gosec
+        path: internal/hmac/
+        text: weak cryptographic primitive
+      - linters:
+          - wrapcheck
+        path: test/mocks
+      - linters:
+          - staticcheck
+        text: 'SA1019:'
+      - linters:
+          - lll
+        source: '^//go:generate '
+      - path: (.+)\.go$
+        text: Using the variable on range scope .* in function literal
+      - path: (.+)\.go$
+        text: should have a package comment
+    paths:
+      - .*\.my\.go$
+      - lib/bad.go
+      - .github
+      - .make
+      - dist
+      - third_party$
+      - builtin$
+      - examples$
 issues:
-  # List of regexps of issue texts to exclude, empty list by default.
-  # But independently of this option we use default exclude patterns,
-  # it can be disabled by `exclude-use-default: false`. To list all
-  # excluded by default patterns execute `golangci-lint run --help`
-  exclude:
-    - Using the variable on range scope .* in function literal
-    - should have a package comment
-
-  # Excluding configuration per-path, per-linter, per-text and per-source
-  exclude-rules:
-    # Exclude some linters from running on tests files.
-    - path: _test\.go
-      linters:
-        - errcheck
-        - gosec
-        - wrapcheck
-        - bodyclose
-
-    - path: /testabilities/
-      linters:
-        - gosec
-        - wrapcheck
-        - bodyclose
-
-    # Exclude known linters from partially "hard-vendored" code,
-    # which is impossible to exclude via "nolint" comments.
-    - path: internal/hmac/
-      text: "weak cryptographic primitive"
-      linters:
-        - gosec
-
-    # Exclude some linters from running on mocks.
-    - path: test/mocks
-      linters:
-        - wrapcheck
-
-    # Exclude some "staticcheck" messages
-    - linters:
-        - staticcheck
-      text: "SA1019:"
-
-    # Exclude lll issues for long lines with go:generate
-    - linters:
-        - lll
-      source: "^//go:generate "
-
-  # Independently of option `exclude` we use default exclude patterns,
-  # it can be disabled by this option. To list all
-  # excluded by default patterns execute `golangci-lint run --help`.
-  # Default value for this option is true.
-  exclude-use-default: false
-
-  # which files to skip: they will be analyzed, but issues from them
-  # won't be reported. Default value is empty list, but there is
-  # no need to include all autogenerated files, we confidently recognize
-  # autogenerated files. If it's not please let us know.
-  # "/" will be replaced by current OS file path separator to properly work
-  # on Windows.
-  exclude-files:
-    - ".*\\.my\\.go$"
-    - lib/bad.go
-  # which dirs to skip: issues from them won't be reported;
-  # can use regexp here: generated.*, regexp is applied on full path;
-  # default value is empty list, but default dirs are skipped independently
-  # of this option's value (see skip-dirs-use-default).
-  # "/" will be replaced by current OS file path separator to properly work
-  # on Windows.
-  exclude-dirs:
-    - .github
-    - .make
-    - dist
-
   # Maximum issues count per one linter. Set to 0 to disable. Default is 50.
   max-issues-per-linter: 0
 
@@ -158,28 +116,16 @@ issues:
 
   # Show only new issues created after git revision `REV`
   new-from-rev: ""
-
 severity:
-  # Default value is empty string.
-  # Set the default severity for issues. If severity rules are defined and the issues
-  # do not match or no severity is provided to the rule this will be the default
-  # severity applied. Severities should match the supported severity names of the
-  # selected out format.
-  # - Code climate: https://docs.codeclimate.com/docs/issues#issue-severity
-  # -   Checkstyle: https://checkstyle.sourceforge.io/property_types.html#severity
-  # -       Github: https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-error-message
-  default-severity: error
-
-  # The default value is false.
-  # If set to true severity-rules regular expressions become case-sensitive.
-  case-sensitive: false
-
-  # Default value is empty list.
-  # When a list of severity rules are provided, severity information will be added to lint
-  # issues. Severity rules have the same filtering capability as exclude rules except you
-  # are allowed to specify one matcher per severity rule.
-  # Only affects out formats that support setting severity information.
+  default: error
   rules:
     - linters:
         - dupl
       severity: info
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$