Fix build config: revert buildSearchableOptions to tasks block, remove unused Java plugin dep (#1)

* Fix build config: revert buildSearchableOptions to tasks block, remove unused Java plugin dep

- Move buildSearchableOptions disable back to tasks block (the extension
  property may not exist in IntelliJ Platform Gradle Plugin 2.3.0)
- Remove bundledPlugin("com.intellij.java") — not used by any source code
- Update foojay-resolver-convention to 1.0.0 (matches JetBrains template)

https://claude.ai/code/session_015LpmjAt17XD582hZ9TPLCv

* Add testFramework dependency and --stacktrace to CI for diagnostics

- Add testFramework(TestFrameworkType.Platform) to dependencies — required
  by IntelliJ Platform Gradle Plugin 2.x for test sandbox setup
- Add --stacktrace to all Gradle commands in CI for better error reporting

https://claude.ai/code/session_015LpmjAt17XD582hZ9TPLCv

* CI: dump test results on failure for diagnostics

https://claude.ai/code/session_015LpmjAt17XD582hZ9TPLCv

* Fix off-by-one errors in HunkMatcher diff remap tests

Two tests passed the wrong oldLine value (off by +1), causing
the remapped result to be 1 higher than expected:
- parseDiffAndRemap with multiple hunks: 6→5
- parseDiffAndRemap with single line hunk: 7→6

Also remove diagnostic CI step no longer needed.

https://claude.ai/code/session_015LpmjAt17XD582hZ9TPLCv

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: jbachorik

.github/workflows/ci.yml

@@ -40,10 +40,10 @@ jobs:
         run: chmod +x gradlew
 
       - name: Build plugin
-        run: ./gradlew buildPlugin
+        run: ./gradlew buildPlugin --stacktrace
 
       - name: Run tests
-        run: ./gradlew test
+        run: ./gradlew test --stacktrace
 
       - name: Upload test results
         if: always()
@@ -84,10 +84,10 @@ jobs:
         run: chmod +x gradlew
 
       - name: Verify plugin descriptor
-        run: ./gradlew verifyPluginConfiguration
+        run: ./gradlew verifyPluginConfiguration --stacktrace
 
       - name: Build plugin distribution
-        run: ./gradlew buildPlugin
+        run: ./gradlew buildPlugin --stacktrace
 
       - name: Upload plugin artifact
         uses: actions/upload-artifact@v4

review-plugin/build.gradle.kts

@@ -21,17 +21,16 @@ kotlin {
 dependencies {
     intellijPlatform {
         intellijIdeaCommunity("2024.1")
-        bundledPlugin("com.intellij.java")
         pluginVerifier()
         instrumentationTools()
+        testFramework(org.jetbrains.intellij.platform.gradle.TestFrameworkType.Platform)
     }
     implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3")
     testImplementation(kotlin("test"))
     testImplementation("junit:junit:4.13.2")
 }
 
 intellijPlatform {
-    buildSearchableOptions = false
     pluginConfiguration {
         id = "com.reviewplugin"
         name = "Agent Review"
@@ -52,4 +51,7 @@ tasks {
     test {
         useJUnit()
     }
+    buildSearchableOptions {
+        enabled = false
+    }
 }

review-plugin/settings.gradle.kts

@@ -6,7 +6,7 @@ pluginManagement {
 }
 
 plugins {
-    id("org.gradle.toolchains.foojay-resolver-convention") version "0.9.0"
+    id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0"
 }
 
 rootProject.name = "review-plugin"

review-plugin/src/test/kotlin/com/reviewplugin/anchor/HunkMatcherTest.kt

@@ -159,7 +159,7 @@ class HunkMatcherTest {
         """.trimIndent()
         // After first hunk: offset = (2+3)-(2+2) = 1
         // Old line 5 is between hunks → 5 - 1 + 1 = 5 (0-based)
-        assertEquals(5, HunkMatcher.parseDiffAndRemap(diff, 6))
+        assertEquals(5, HunkMatcher.parseDiffAndRemap(diff, 5))
     }
 
     @Test
@@ -174,7 +174,7 @@ class HunkMatcherTest {
         // Old line 5 is in the hunk (5..5)
         assertNull(HunkMatcher.parseDiffAndRemap(diff, 5))
         // Old line 6 is after: offset = (5+2)-(5+1) = 1, result = 6-1+1 = 6
-        assertEquals(6, HunkMatcher.parseDiffAndRemap(diff, 7))
+        assertEquals(6, HunkMatcher.parseDiffAndRemap(diff, 6))
     }
 
     // ── fuzzySearch ─────────────────────────────────────────────────