Skip to content

Commit 8df8a1a

Browse files
morbidrsakdave
authored andcommitted
btrfs: fix copying the flags of btrfs_bio after split
When a btrfs_bio gets split, only 'bbio->csum_search_commit_root' gets copied to the new btrfs_bio, all the other flags don't. When a bio is split in btrfs_submit_chunk(), btrfs_split_bio() creates the new split bio via btrfs_bio_init() which zeroes the struct with memset. Looking at btrfs_split_bio(), it copies csum_search_commit_root from the original but does not copy can_use_append. After the split, the code does: bbio = split; bio = &bbio->bio; This means the split bio (with can_use_append = false) gets submitted, not the original. In btrfs_submit_dev_bio(), the condition: if (btrfs_bio(bio)->can_use_append && btrfs_dev_is_sequential(...)) Will be false for the split bio even when writing to a sequential zone. Does the split bio need to inherit can_use_append from the original? The old code used a local variable use_append which persisted across the split. Copy the rest of the flags as well. Link: https://lore.kernel.org/linux-btrfs/20260125132120.2525146-1-clm@meta.com/ Reported-by: Chris Mason <clm@meta.com> Reviewed-by: Qu Wenruo <wqu@suse.com> Reviewed-by: Boris Burkov <boris@bur.io> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 75becc7 commit 8df8a1a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

fs/btrfs/bio.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,13 @@ static struct btrfs_bio *btrfs_split_bio(struct btrfs_fs_info *fs_info,
9797
bbio->orig_logical = orig_bbio->orig_logical;
9898
orig_bbio->orig_logical += map_length;
9999
}
100+
100101
bbio->csum_search_commit_root = orig_bbio->csum_search_commit_root;
102+
bbio->can_use_append = orig_bbio->can_use_append;
103+
bbio->is_scrub = orig_bbio->is_scrub;
104+
bbio->is_remap = orig_bbio->is_remap;
105+
bbio->async_csum = orig_bbio->async_csum;
106+
101107
atomic_inc(&orig_bbio->pending_ios);
102108
return bbio;
103109
}

0 commit comments

Comments
 (0)