Skip to content

Commit 4c45a4c

Browse files
committed
Fix --http_metrics_prefix help text
urfave/cli interprets backticks as referring to a placeholder variable, but this is a boolean flag with no option/variable.
1 parent 63d0ec4 commit 4c45a4c

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -436,9 +436,8 @@ OPTIONS:
436436
endpoint. (default: false, ie disable metrics)
437437
[$BAZEL_REMOTE_ENABLE_ENDPOINT_METRICS]
438438
439-
--http_metrics_prefix Prefix HTTP metrics names with `bazel_remote`
440-
(default: false, ie no prefix)
441-
[$BAZEL_REMOTE_HTTP_METRICS_PREFIX]
439+
--http_metrics_prefix Whether to prefix http metrics with "bazel_remote"
440+
or not (default: false, ie no prefix) [$BAZEL_REMOTE_HTTP_METRICS_PREFIX]
442441
443442
--experimental_remote_asset_api Whether to enable the experimental remote
444443
asset API implementation. (default: false, ie disable remote asset API)

utils/flags/flags.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ func GetCliFlags() []cli.Flag {
489489
},
490490
&cli.BoolFlag{
491491
Name: "http_metrics_prefix",
492-
Usage: "Whether to prefix http metrics with `bazel_remote` or not",
492+
Usage: "Whether to prefix http metrics with \"bazel_remote\" or not",
493493
DefaultText: "false, ie no prefix",
494494
EnvVars: []string{"BAZEL_REMOTE_HTTP_METRICS_PREFIX"},
495495
},

0 commit comments

Comments
 (0)