Skip to content

Commit 00784fe

Browse files
author
Lloyd Watkin
committed
Add test for <rating/> element
1 parent 79f4f05 commit 00784fe

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed

src/main/java/org/buddycloud/channelserver/channel/ValidateEntry.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,12 @@ public Element getPayload() {
234234
.setText(globalTargetId.toString());
235235
target.addElement("activity:object-type").setText("post");
236236
}
237+
238+
if (itemRating > 0) {
239+
entry.addNamespace("review", NS_REVIEW);
240+
String rating = String.format("%d.0", itemRating);
241+
entry.addElement("review:rating").setText(rating);
242+
}
237243

238244
return entry;
239245
}

src/test/java/org/buddycloud/channelserver/channel/ValidateEntryTest.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -554,5 +554,21 @@ public void nonWholeNumberRatingReturnsError() throws Exception {
554554
Assert.assertEquals(ValidateEntry.INVALID_RATING_VALUE,
555555
validateEntry.getErrorMessage());
556556
}
557+
558+
@Test
559+
public void ratingElementGetsAddedToPayloadAsExpected() throws Exception {
560+
561+
String rating = "4";
562+
563+
Element entry = (Element) this.ratingEntry.clone();
564+
entry.element("rating").setText(rating);
565+
entry.element("target").element("id").setText("1");
566+
validateEntry = getEntryObject(entry);
567+
568+
Assert.assertTrue(validateEntry.isValid());
569+
Element payload = validateEntry.getPayload();
570+
571+
Assert.assertEquals(rating + ".0", payload.element("rating").getTextTrim());
572+
}
557573

558574
}

0 commit comments

Comments
 (0)