Prevent 'liking a like'

Author: Lloyd Watkin

src/main/java/org/buddycloud/channelserver/channel/ValidateEntry.java

@@ -63,6 +63,7 @@ public class ValidateEntry {
 	private String node;
 	private ChannelManager channelManager;
 	private NodeItem replyingToItem;
+	private NodeItem targetItem;
 
 	Map<String, String> params = new HashMap<String, String>();
 
@@ -247,7 +248,6 @@ public Element getPayload() {
 		Element activityObject = entry.addElement("activity:object");
 		activityObject.addElement("activity:object-type").setText(postType);
 
-		
 		return entry;
 	}
 
@@ -305,7 +305,6 @@ private boolean validateTargetElement(Element target)
 		if (true == GlobalItemIDImpl.isGlobalId(targetId)) {
 			targetId = GlobalItemIDImpl.toLocalId(targetId);
 		}
-		NodeItem targetItem;
 		if (true == targetId.equals(replyingToItem.getId())) {
 			targetItem = replyingToItem;
 		} else {
@@ -338,6 +337,10 @@ private boolean validateRatingElement(Element rating) {
 			this.errorMessage = TARGET_ELEMENT_MISSING;
 			return false;
 		}
+		if (targetItem.getPayload().indexOf(NS_REVIEW) > -1) {
+			this.errorMessage = CAN_ONLY_RATE_A_POST;
+			return false;
+		}
 		try {
 		    double itemRatingFloat = Double.parseDouble(rating.getTextTrim());
 		    if (itemRatingFloat != Math.floor(itemRatingFloat)) {

src/test/java/org/buddycloud/channelserver/channel/ValidateEntryTest.java

@@ -613,5 +613,23 @@ public void postContentGetsReplacedWithRating() throws Exception {
 
 		Assert.assertEquals(expectedContent, payload.elementText("content"));
     }
+    
+    @Test
+    public void canNotRateARating() throws Exception {
+    	String testPayload = "<entry xmlns=\"http://www.w3.org/2005/Atom\" " +
+            "xmlns:review=\"http://activitystrea.ms/schema/1.0/review\">" +
+    		"<review:rating>5.0</review:rating></entry>";
+		NodeItem item = new NodeItemImpl(node, "1", new Date(), testPayload);
+		Mockito.when(
+				channelManager.getNodeItem(Mockito.eq(node),
+						Mockito.anyString())).thenReturn(item);
+    	
+    	Element entry = (Element) this.ratingEntry.clone();
+		entry.element("target").element("id").setText("1");
+		validateEntry = getEntryObject(entry);
+		
+		Assert.assertFalse(validateEntry.isValid());
+		Assert.assertEquals(ValidateEntry.CAN_ONLY_RATE_A_POST, validateEntry.getErrorMessage());
+    }
 
 }