LSP remove verbose debug logging (#4123)

Author: emcfarlane

private/buf/buflsp/buflsp.go

@@ -127,12 +127,10 @@ func (l *lsp) newHandler() jsonrpc2.Handler {
 		l.logger.Debug(
 			"handling request",
 			slog.String("method", req.Method()),
-			slog.Any("params", req.Params()),
 		)
 		defer xslog.DebugProfile(
 			l.logger,
 			slog.String("method", req.Method()),
-			slog.Any("params", req.Params()),
 		)()
 
 		replier := l.wrapReplier(reply, req)

private/buf/buflsp/completion.go

@@ -60,8 +60,6 @@ func getCompletionItems(
 			ctx,
 			"completion: found declaration",
 			slog.String("decl_kind", decl.Kind().String()),
-			slog.Any("decl_span_start", decl.Span().StartLoc()),
-			slog.Any("decl_span_end", decl.Span().EndLoc()),
 			slog.Int("path_depth", len(declPath)),
 		)
 	} else {
@@ -160,8 +158,6 @@ func completionItemsForDef(ctx context.Context, file *file, declPath []ast.DeclA
 		slog.String("name", def.Name().Span().String()),
 		slog.String("def_kind", def.Classify().String()),
 		slog.Int("path_depth", len(declPath)),
-		slog.Any("decl_span_start", def.Span().StartLoc()),
-		slog.Any("decl_span_end", def.Span().EndLoc()),
 	)
 
 	// Check if cursor is in the name of the definition, if so ignore.

private/buf/buflsp/file.go

@@ -275,7 +275,6 @@ func (f *file) RefreshIR(ctx context.Context) {
 		ctx, "ir diagnostic(s)",
 		slog.String("uri", f.uri.Filename()),
 		slog.Int("count", len(f.diagnostics)),
-		slog.Any("diagnostics", f.diagnostics),
 	)
 }
 
@@ -661,12 +660,11 @@ func (f *file) SymbolAt(ctx context.Context, cursor protocol.Position) *symbol {
 		idx--
 	}
 	symbol := f.symbols[idx]
-	f.lsp.logger.DebugContext(ctx, "found symbol", slog.Any("symbol", symbol))
 	// Check that cursor is before the end of the symbol. Range is half-open [Start, End).
 	if comparePositions(symbol.Range().End, cursor) < 0 {
 		return nil
 	}
-
+	f.lsp.logger.DebugContext(ctx, "found symbol", slog.Any("symbol", symbol))
 	return symbol
 }
 

private/buf/buflsp/jsonrpc_wrappers.go

@@ -35,7 +35,6 @@ func (l *lsp) wrapReplier(reply jsonrpc2.Replier, req jsonrpc2.Request) jsonrpc2
 			l.logger.Debug(
 				"responding",
 				slog.String("method", req.Method()),
-				slog.Any("params", result),
 			)
 		}
 
@@ -58,7 +57,6 @@ func (c *connWrapper) Call(
 	c.logger.Debug(
 		"call",
 		slog.String("method", method),
-		slog.Any("params", params),
 	)
 
 	id, err = c.Conn.Call(ctx, method, params, result)
@@ -72,7 +70,6 @@ func (c *connWrapper) Call(
 		c.logger.Debug(
 			"call returned",
 			slog.String("method", method),
-			slog.Any("result", result),
 		)
 	}
 
@@ -84,7 +81,6 @@ func (c *connWrapper) Notify(
 	c.logger.Debug(
 		"notify",
 		slog.String("method", method),
-		slog.Any("params", params),
 	)
 
 	err := c.Conn.Notify(ctx, method, params)

private/buf/buflsp/symbol.go

@@ -165,16 +165,18 @@ func (s *symbol) LogValue() slog.Value {
 		)
 	}
 	attrs := []slog.Attr{
-		slog.String("file", s.span.Path()),
+		slog.String("path", s.span.Path()),
 		slog.Any("start", loc(s.span.StartLoc())),
 		slog.Any("end", loc(s.span.EndLoc())),
 	}
 	if imported, ok := s.kind.(*imported); ok {
 		attrs = append(attrs, slog.String("imported", imported.file.uri.Filename()))
 	} else if s.def != nil {
-		attrs = append(attrs, slog.String("def_file", s.def.file.uri.Filename()))
-		attrs = append(attrs, slog.Any("def_start", loc(s.def.span.StartLoc())))
-		attrs = append(attrs, slog.Any("def_end", loc(s.def.span.EndLoc())))
+		attrs = append(attrs,
+			slog.String("uri", s.def.file.uri.Filename()),
+			slog.Any("start", loc(s.span.StartLoc())),
+			slog.Any("end", loc(s.span.EndLoc())),
+		)
 	}
 	return slog.GroupValue(attrs...)
 }