You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: private/buf/cmd/buf/buf_test.go
+3-3Lines changed: 3 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -2893,7 +2893,7 @@ testdata/check_plugins/current/proto/api/v1/service.proto:17:14:RPC request type
2893
2893
testdata/check_plugins/current/proto/api/v1/service.proto:17:42:RPC response type "GetFooTestResponse" should be named "GetFooResponse" or "FooServiceTestGetFooResponse".
2894
2894
testdata/check_plugins/current/proto/api/v1/service.proto:26:1:"ListFooResponse" is a pagination response without a page token field named "page_token" (buf-plugin-rpc-ext)
2895
2895
testdata/check_plugins/current/proto/common/v1alpha1/messages.proto:16:5:field "common.v1alpha1.Four.FourTwo.id" does not have rule (buf.validate.field).string.tuuid set (buf-plugin-protovalidate-ext)
2896
-
testdata/check_plugins/current/vendor/protovalidate/buf/validate/validate.proto:94:3:field "buf.validate.Constraint.id" does not have rule (buf.validate.field).string.tuuid set (buf-plugin-protovalidate-ext)
2896
+
testdata/check_plugins/current/vendor/protovalidate/buf/validate/validate.proto:94:3:field "buf.validate.Rule.id" does not have rule (buf.validate.field).string.tuuid set (buf-plugin-protovalidate-ext)
@@ -2919,7 +2919,7 @@ testdata/check_plugins/current/proto/api/v1/service.proto:17:14:RPC request type
2919
2919
testdata/check_plugins/current/proto/api/v1/service.proto:17:42:RPC response type "GetFooTestResponse" should be named "GetFooResponse" or "FooServiceTestGetFooResponse".
2920
2920
testdata/check_plugins/current/proto/api/v1/service.proto:26:1:"ListFooResponse" is a pagination response without a page token field named "page_token" (buf-plugin-rpc-ext)
2921
2921
testdata/check_plugins/current/proto/common/v1alpha1/messages.proto:16:5:field "common.v1alpha1.Four.FourTwo.id" does not have rule (buf.validate.field).string.tuuid set (buf-plugin-protovalidate-ext)
2922
-
testdata/check_plugins/current/vendor/protovalidate/buf/validate/validate.proto:94:3:field "buf.validate.Constraint.id" does not have rule (buf.validate.field).string.tuuid set (buf-plugin-protovalidate-ext)
2922
+
testdata/check_plugins/current/vendor/protovalidate/buf/validate/validate.proto:94:3:field "buf.validate.Rule.id" does not have rule (buf.validate.field).string.tuuid set (buf-plugin-protovalidate-ext)
testdata/check_plugins/current/proto/api/v1/service.proto:11:1:Service name "api.v1.FooServiceMock" has banned suffix "Mock". (buf-plugin-suffix)
2971
2971
testdata/check_plugins/current/proto/common/v1alpha1/messages.proto:16:5:field "common.v1alpha1.Four.FourTwo.id" does not have rule (buf.validate.field).string.tuuid set (buf-plugin-protovalidate-ext)
2972
-
testdata/check_plugins/current/vendor/protovalidate/buf/validate/validate.proto:94:3:field "buf.validate.Constraint.id" does not have rule (buf.validate.field).string.tuuid set (buf-plugin-protovalidate-ext)
2972
+
testdata/check_plugins/current/vendor/protovalidate/buf/validate/validate.proto:94:3:field "buf.validate.Rule.id" does not have rule (buf.validate.field).string.tuuid set (buf-plugin-protovalidate-ext)
Copy file name to clipboardExpand all lines: private/bufpkg/bufcheck/bufcheckserver/internal/buflintvalidate/adder.go
+9-9Lines changed: 9 additions & 9 deletions
Original file line number
Diff line number
Diff line change
@@ -21,25 +21,25 @@ import (
21
21
)
22
22
23
23
// The typical use of adder is calling adder.addForPathf([]int32{int64RulesFieldNumber, someFieldNumber}, "message")
24
-
// from checkConstraintsForField (or a function that it calls). Notice that checkConstraintsForField
24
+
// from checkRulesForField (or a function that it calls). Notice that checkRulesForField
25
25
// is recursive, because it can call checkMapRules and checkRepeatedRules, both of which can
26
-
// call checkConstraintsForField.
26
+
// call checkRulesForField.
27
27
//
28
-
// If checkConstraintsForField is called by checkMapRules, when we add a file annotation, the
28
+
// If checkRulesForField is called by checkMapRules, when we add a file annotation, the
29
29
// location should be for something like `repeated.items.string.max_len`. We need to search for the
30
30
// location by a path like [mapRulesFieldNumber, keysFieldNumber, StringRulesFieldNumber, ...].
31
31
//
32
-
// If checkConstraintsForField is not in a recursive call, when we add a file annotation, the
32
+
// If checkRulesForField is not in a recursive call, when we add a file annotation, the
33
33
// location should be for something like `string.max_len`. We need to search for the location by
34
34
// a path like [int64RulesFieldNumber, ...].
35
35
//
36
-
// However, from checkConstraintsForField's perspective, it doesn't know whether it's in a recursive
36
+
// However, from checkRulesForField's perspective, it doesn't know whether it's in a recursive
37
37
// call. It always treats the path like [int64RulesFieldNumber, ...], as opposed to [mapRulesFieldNumber, keysFieldNumber, StringRulesFieldNumber, ...].
38
38
// To preserve the first part of the path, [mapRulesFieldNumber, keysFieldNumber], we create a new adder
39
-
// with a base path when we recursively call checkConstraintsForField. The new adder will automatically
39
+
// with a base path when we recursively call checkRulesForField. The new adder will automatically
40
40
// prepend the base path whenever it searches for a location. This is manageable because the recursion
41
-
// depth is at most 2 -- if checkMapRules or checkRepeatedRules calls checkConstraintsForField,
42
-
// this call of checkConstraintsForField won't call checkMapRules or checkRepeatedRules.
41
+
// depth is at most 2 -- if checkMapRules or checkRepeatedRules calls checkRulesForField,
42
+
// this call of checkRulesForField won't call checkMapRules or checkRepeatedRules.
43
43
typeadderstruct {
44
44
field bufprotosource.Field
45
45
fieldPrettyTypeNamestring
@@ -96,7 +96,7 @@ func (a *adder) fieldName() string {
0 commit comments