Use name of length rule rather than const for PROTOVALIDATE length checks (#4253)

doriable · web-flow · commit 5fb6a08f69f4 · 2026-01-05T12:51:27.000-05:00
diff --git a/private/bufpkg/bufcheck/bufcheckserver/internal/buflintvalidate/field.go b/private/bufpkg/bufcheck/bufcheckserver/internal/buflintvalidate/field.go
@@ -1172,11 +1172,12 @@ func checkLenRules(
 				{ruleFieldNumber, minLenFieldNumber},
 				{ruleFieldNumber, maxLenFieldNumber},
 			},
-			"Field %q has equal %s and %s, use %s.const instead.",
+			"Field %q has equal %s and %s, use %s.%s instead.",
 			adder.fieldName(),
 			adder.getFieldRuleName(ruleFieldNumber, minLenFieldNumber),
 			maxLenFieldName,
 			adder.getFieldRuleName(ruleFieldNumber),
+			lenFieldName,
 		)
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -1172,11 +1172,12 @@ func checkLenRules(`
`1172`	`1172`	`{ruleFieldNumber, minLenFieldNumber},`
`1173`	`1173`	`{ruleFieldNumber, maxLenFieldNumber},`
`1174`	`1174`	`},`
`1175`		`- "Field %q has equal %s and %s, use %s.const instead.",`
	`1175`	`+ "Field %q has equal %s and %s, use %s.%s instead.",`
`1176`	`1176`	`adder.fieldName(),`
`1177`	`1177`	`adder.getFieldRuleName(ruleFieldNumber, minLenFieldNumber),`
`1178`	`1178`	`maxLenFieldName,`
`1179`	`1179`	`adder.getFieldRuleName(ruleFieldNumber),`
	`1180`	`+ lenFieldName,`
`1180`	`1181`	`)`
`1181`	`1182`	`}`
`1182`	`1183`	`return nil`