Fix build 32-bit for LSP completion (#4125)

Author: emcfarlane

private/buf/buflsp/completion.go

@@ -612,47 +612,31 @@ func typeReferencesToCompletionItems(
 			}
 		}
 	}
-	var lastImportLine uint32
+	var lastImportLine int64
 	currentImportPaths := map[string]struct{}{}
 	for currentFileImport := range seq.Values(current.ir.Imports()) {
-		l := currentFileImport.Decl.Span().EndLoc().Line
-		if l < 0 || l > math.MaxUint32 {
-			continue // skip this import; exceptional case.
-		}
-		lastImportLine = max(uint32(l), lastImportLine)
+		lastImportLine = max(lastImportLine, int64(currentFileImport.Decl.Span().EndLoc().Line))
 		currentImportPaths[currentFileImport.Path()] = struct{}{}
 	}
-	var insertPosition protocol.Position
-	if lastImportLine != 0 {
-		// add an additionalTextEdit to the end of the current imports, which can then be tidied by
-		// `buf format` to go in it's proper location.
-		insertPosition = protocol.Position{
-			Line:      lastImportLine,
-			Character: 0,
-		}
-	} else {
+	if lastImportLine == 0 {
 		// If lastImportLine is 0, we have no imports in this file; put it after `package`, if
 		// package exists. Otherwise, after `syntax`, if it exists. Otherwise, balk.
 		// NOTE: We simply want to add the import on the next line (which may not be how `buf
 		// format` would format the file); we leave the overall file formatting to `buf format`.
-		var line int
 		switch {
 		case !current.ir.AST().Package().IsZero():
-			line = current.ir.AST().Package().Span().EndLoc().Line
+			lastImportLine = int64(current.ir.AST().Package().Span().EndLoc().Line)
 		case !current.ir.AST().Syntax().IsZero():
-			line = current.ir.AST().Syntax().Span().EndLoc().Line
-		default:
-			line = 0
-		}
-		if line < 0 || line > math.MaxUint32 {
-			// Nothing to do; exceptional case.
-		} else {
-			insertPosition = protocol.Position{
-				Line:      uint32(line),
-				Character: 0,
-			}
+			lastImportLine = int64(current.ir.AST().Syntax().Span().EndLoc().Line)
 		}
 	}
+	if lastImportLine < 0 || lastImportLine > math.MaxUint32 {
+		lastImportLine = 0 // Default to insert at top of page.
+	}
+	importInsertPosition := protocol.Position{
+		Line:      uint32(lastImportLine),
+		Character: 0,
+	}
 	parentPrefix := string(parentFullName) + "."
 	packagePrefix := string(current.ir.Package()) + "."
 	return func(yield func(protocol.CompletionItem) bool) {
@@ -700,8 +684,8 @@ func typeReferencesToCompletionItems(
 				additionalTextEdits = append(additionalTextEdits, protocol.TextEdit{
 					NewText: "import " + `"` + symbolFile + `";` + "\n",
 					Range: protocol.Range{
-						Start: insertPosition,
-						End:   insertPosition,
+						Start: importInsertPosition,
+						End:   importInsertPosition,
 					},
 				})
 			}