Forward the input image resolver to protovalidate so it can support predefined rule#4357
Merged
doriable merged 1 commit intobufbuild:mainfrom Feb 25, 2026
Merged
Conversation
|
|
jeremie-stripe
changed the title
Member
|
hey @jeremie-stripe, looks good to me — could you just change your PR title's first word to not end in "s", please? (Sorry, it's a silly regex but it helps us keep in the imperative tone.) |
jeremie-stripe
changed the title
jeremie-stripe
changed the title
Contributor
Author
|
@stefanvanburen did "Pass" --> "Forward", hopefully that does the trick! |
doriable
approved these changes
Feb 25, 2026
Member
doriable
left a comment
doriable
left a comment
There was a problem hiding this comment.
This looks very reasonable to me, thank you! It will be available on the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple change allow the
--validateoption ofbuf convertto locate custom rules (as documented in https://protovalidate.com/schemas/predefined-rules/) as long as they are included in the input (e.g. via a protoset).