Skip to content

Add static buf.yaml files for protovalidate and protovalidate-testing#694

Merged
unmultimedio merged 3 commits intomainfrom
jfigueroa/pv-static-buf-yaml
May 14, 2025
Merged

Add static buf.yaml files for protovalidate and protovalidate-testing#694
unmultimedio merged 3 commits intomainfrom
jfigueroa/pv-static-buf-yaml

Conversation

@unmultimedio
Copy link
Member

@unmultimedio unmultimedio commented Sep 6, 2024

Similar treatment than #579, waiting if/when protovalidate moves to v2: bufbuild/protovalidate#233

@github-actions
Copy link

github-actions bot commented Sep 6, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 14, 2025, 7:34 PM

@nicksnyder
Copy link
Member

What is the deal with this PR?

@smaye81
Copy link
Contributor

smaye81 commented May 14, 2025

Following up on this -- I recently put up bufbuild/protovalidate#366 to migrate to a v2 buf.yaml file, unaware of some of the obstacles. What is the status of being able to support it? @unmultimedio

@unmultimedio
Copy link
Member Author

Following up on this -- I recently put up bufbuild/protovalidate#366 to migrate to a v2 buf.yaml file, unaware of some of the obstacles. What is the status of being able to support it? @unmultimedio

Sure we're ready if you wanna move to v2, see this comment bufbuild/protovalidate#233 (comment). If we decide to do it, this PR should be merged first, and then you can bump pv to v2.

Lmk to update+merge this one first.

@smaye81
Copy link
Contributor

smaye81 commented May 14, 2025

Sure we're ready if you wanna move to v2, see this comment bufbuild/protovalidate#233 (comment). If we decide to do it, this PR should be merged first, and then you can bump pv to v2.

Lmk to update+merge this one first.

Great. I'm ready if others think we're ok @rodaine @timostamm

@smaye81
Copy link
Contributor

smaye81 commented May 14, 2025

Think we're ready to when you are @unmultimedio thanks!

version: v1
name: buf.build/bufbuild/protovalidate-testing
deps:
- buf.build/bufbuild/protovalidate
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pinning to any specific version, so in case there are multiple breaking changes sequentially, a manual release of this repo needs to be done in between them to ensure synced remote dependencies don't break. See bufbuild/protovalidate#233 (comment)

@unmultimedio unmultimedio changed the title [DO NOT MERGE] Add static buf.yaml files for protovalidate and protovalidate-testing Add static buf.yaml files for protovalidate and protovalidate-testing May 14, 2025
@unmultimedio unmultimedio merged commit fa98c7a into main May 14, 2025
6 of 7 checks passed
@unmultimedio unmultimedio deleted the jfigueroa/pv-static-buf-yaml branch May 14, 2025 19:37
@unmultimedio
Copy link
Member Author

Think we're ready to when you are @unmultimedio thanks!

@smaye81 this is merged! feel free to merge yours, and I'll ping you when the next release for both pv and pvt is being synced here, to sanity check this went fine.

smaye81 added a commit to bufbuild/protovalidate that referenced this pull request May 15, 2025
This is a small cleanup PR to convert the repo to use the v2 config for
`buf.yaml`. It deletes the individual files in the proto directory in
favor of a single one at the root which defines both modules.

Also deleted `buf.work.yaml` and `buf.lock` since deps for local modules
are handled by Buf.

Note: should be merged _after_
bufbuild/modules#694
@smaye81
Copy link
Contributor

smaye81 commented May 15, 2025

Just merged #366 @unmultimedio. Lmk if things look ok whenever.

@unmultimedio
Copy link
Member Author

Just merged #366 @unmultimedio. Lmk if things look ok whenever.

Sure, this repo will pick things up the next semver release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants