Ensure ignore_versions is respected for shared sources (#2138)

Author: pkwarren

internal/cmd/fetcher/main.go

@@ -11,6 +11,7 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"slices"
 	"strings"
 	"time"
 
@@ -175,6 +176,12 @@ func run(ctx context.Context, root string) ([]createdPlugin, error) {
 			}
 			latestVersions[config.CacheKey()] = newVersion
 		}
+		// Some plugins share the same source but specify different ignore versions.
+		// Ensure we continue to only fetch the latest version once but still respect ignores.
+		if slices.Contains(config.Source.IgnoreVersions, newVersion) {
+			log.Printf("skipping source: %s: %v", config.Filename, newVersion)
+			continue
+		}
 		// example: plugins/grpc
 		pluginDir := filepath.Dir(config.Filename)
 		ok, err := checkDirExists(filepath.Join(pluginDir, newVersion))

plugins/bufbuild/validate-java/source.yaml

@@ -1,6 +1,7 @@
 source:
   ignore_versions:
-    - v1.3.0 # Temporarily ignore version until a release is published.
+    # Temporarily ignore version until a release is published.
+    - v1.3.0
   github:
     owner: bufbuild
     repository: protoc-gen-validate