Skip to content

Support buf.validate.oneof for Valid Types #1171

@ryancerf

Description

@ryancerf

If (buf.validate.oneof).required = true; is used should the union for the valid msg exclude the undefined variant?

message MyOneOf {
  oneof variant {
    option (buf.validate.oneof).required = true;
    string value1 = 1;
    string value2 = 2;
  }
}
/**
 * @generated from message inputs.model.v1.MyOneOf
 */
export type MyOneOf = Message<"inputs.model.v1.MyOneOf"> & {
  /**
   * @generated from oneof inputs.model.v1.MyOneOf.variant
   */
  variant: {
    /**
     * @generated from field: string value1 = 1;
     */
    value: string;
    case: "value1";
  } | {
    /**
     * @generated from field: string value2 = 2;
     */
    value: string;
    case: "value2";
  } | { case: undefined; value?: undefined };
};

export type MyOneOfValid = MyOneOf;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions