Fix issues with repeated enums with unique, defined_only, in and not_in for cc and go#1360
Open
fishcakez wants to merge 1 commit intobufbuild:mainfrom
Open
Fix issues with repeated enums with unique, defined_only, in and not_in for cc and go#1360fishcakez wants to merge 1 commit intobufbuild:mainfrom
fishcakez wants to merge 1 commit intobufbuild:mainfrom
Conversation
Signed-off-by: James Fish <jfish@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use repeated enums with
unique,defined_only,inornot_inencountered issues with cc and go implementations.For go, the generated code for repeated enum when using
defined_onlycould be incorrect when importing enums from multiple packages with name collisions. The imports are correct (e.g._go,_go1) but the defined check would always use the first case (e.g._go). The test added will fail to compile without the fix:For cc, then generated code for repeated enum when using
uniquehas issue with const_cast from int -> enum. Therefore for repeated unique enum use set of int to avoid cast/reference wrapper. The tested added will fail to compile without the fix:For cc, the generated code for repeated enum when using
inornot_inhas incorrect namespace where::separator is not used, and instead_is. Therefore use correct package name helper for cc. The test added will fail to compile without the fix: