https://github.com/bufbuild/protoc-gen-validate/issues/672#1374
Closed
qjw wants to merge 1 commit intobufbuild:mainfrom
Closed
https://github.com/bufbuild/protoc-gen-validate/issues/672#1374qjw wants to merge 1 commit intobufbuild:mainfrom
qjw wants to merge 1 commit intobufbuild:mainfrom
Conversation
当一个文件引用了多个package的定义,并且都加入校验 [(validate.rules).enum.defined_only = true] ,如果这几个包的后缀都相同,例如/v1 , 生成的go代码 package alias 有问题 另外一个改动是为了避免太多diff, 回退了一个没啥影响的代码改动
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当一个文件引用了多个package的定义,并且都加入校验 [(validate.rules).enum.defined_only = true] ,如果这几个包的后缀都相同,例如/v1 , 生成的go代码 package alias 有问题
另外一个改动是为了避免太多diff, 回退了一个没啥影响的代码改动