Skip to content

Commit 04469d0

Browse files
Clean up CONTRIBUTING.md (#383)
* No need to specify an alternate python to `uv`; it manages python versions * Remove "Language Support Requirements" (likely copy-pasta from the protovalidate repo)
1 parent a264f9e commit 04469d0

File tree

1 file changed

+2
-28
lines changed

1 file changed

+2
-28
lines changed

.github/CONTRIBUTING.md

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ cd protovalidate-python
2121

2222
Next, install dependencies. You will need:
2323

24-
* Python >=v3.9
2524
* [uv](https://docs.astral.sh/uv/)
2625

2726
We use a Makefile to test and lint our code, so you'll also need a few non-Python tools:
@@ -34,9 +33,8 @@ We use a Makefile to test and lint our code, so you'll also need a few non-Pytho
3433
directly from upstream](https://go.dev/doc/install).
3534

3635
With Go and GNU Make installed, you can verify that your changes pass tests and
37-
lint checks by running `make`. If your Python 3 interpreter isn't available as
38-
`python3`, try `UV_PYTHON=python make`. For a list of other useful commands, run
39-
`make help`.
36+
lint checks by running `make`. For a list of other useful commands, run `make
37+
help`.
4038

4139
### Reporting Bugs
4240

@@ -94,29 +92,6 @@ For changes, improvements, or fixes, please create a pull request. Make sure
9492
your PR is up-to-date with the main branch. Please write clear and concise
9593
commit messages to help us understand and review your PR.
9694

97-
## Language Support Requirements
98-
99-
We aim for `protovalidate-python` to support multiple languages, including but not
100-
limited to Go, Java, Python, C++, and Typescript. Here are the requirements for
101-
adding a new language:
102-
103-
1. __Conformance__: Make sure that your language addition passes the conformance
104-
test suite. This ensures that your addition meets the project's standards and
105-
behaves as expected.
106-
107-
2. __CEL Interpreter__: Implement a Common Expression Language (CEL) interpreter
108-
in your chosen language. CEL is a non-Turing complete language that makes it
109-
easy to write simple expressions, and it's crucial to `protovalidate-python`.
110-
111-
3. __Custom Function Equivalence__: Ensure that custom functions have equivalent
112-
behavior across all languages. This uniformity is essential to maintain the
113-
integrity and consistency of the project. Check out
114-
the [Custom Functions][custom-funcs] for more
115-
116-
If you are interested in adding a new language to `protovalidate-python`, please open
117-
an issue to discuss the details and requirements. We will be more than happy to
118-
guide you through the process.
119-
12095
### Minimizing Performance Regression
12196

12297
Performance and efficient resource management are critical aspects
@@ -175,6 +150,5 @@ working together to make `protovalidate-python` the best it can be.
175150
[code-of-conduct]: https://github.com/bufbuild/protovalidate/tree/main/.github/CODE_OF_CONDUCT.md
176151
[issues]: https://github.com/bufbuild/protovalidate-python/issues
177152
[file-bug]: https://github.com/bufbuild/protovalidate-python/issues/new?assignees=&labels=Bug&template=bug_report.md&title=%5BBUG%5D
178-
[custom-funcs]: https://github.com/bufbuild/protovalidate/tree/main/docs/cel.md#custom-library-in-protovalidate
179153
[file-feature-request]: https://github.com/bufbuild/protovalidate-python/issues/new?assignees=&labels=Feature&template=feature_request.md&title=%5BFeature+Request%5D
180154
[cel-spec]: https://github.com/google/cel-spec

0 commit comments

Comments
 (0)