Skip to content

Commit 42bfa58

Browse files
Support protobuf==5 (#358)
We want to support protobuf==5 && protobuf==6 (and not restrict the eventual jump to 7). We'll presumably drop support for 5 when 7 is released, and re-lock our minimum at 6. Resolves #356.
1 parent b538a8c commit 42bfa58

File tree

87 files changed

+95
-589
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+95
-589
lines changed

.github/workflows/ci.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ jobs:
1919
matrix:
2020
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
2121
resolution: ["highest", "lowest-direct"]
22+
env:
23+
# Shared env variables for all the tests
24+
UV_RESOLUTION: '${{ matrix.resolution }}'
2225
steps:
2326
- name: Checkout code
2427
uses: actions/checkout@v5
@@ -32,8 +35,8 @@ jobs:
3235
- uses: astral-sh/setup-uv@v6
3336
with:
3437
python-version: ${{ matrix.python-version }}
35-
- name: Install dependencies with resolution ${{ matrix.resolution }}
36-
run: UV_RESOLUTION=${{ matrix.resolution }} make install
38+
- name: Install dependencies
39+
run: make install
3740
- name: Execute tests
3841
run: make test
3942
- name: Lint

buf.gen.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ version: v2
22
managed:
33
enabled: true
44
plugins:
5-
# NOTE: v30.0 is the earliest version supporting protobuf==6.
6-
- remote: buf.build/protocolbuffers/python:v30.0
5+
# NOTE: v26.0 is the earliest version supporting protobuf==5.
6+
- remote: buf.build/protocolbuffers/python:v26.0
77
out: gen
8-
- remote: buf.build/protocolbuffers/pyi:v30.0
8+
- remote: buf.build/protocolbuffers/pyi:v26.0
99
out: gen

gen/buf/validate/conformance/cases/bool_pb2.py

Lines changed: 1 addition & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/buf/validate/conformance/cases/bytes_pb2.py

Lines changed: 1 addition & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/buf/validate/conformance/cases/custom_rules/custom_rules_pb2.py

Lines changed: 1 addition & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/buf/validate/conformance/cases/custom_rules/custom_rules_pb2.pyi

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/buf/validate/conformance/cases/enums_pb2.py

Lines changed: 1 addition & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/buf/validate/conformance/cases/enums_pb2.pyi

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/buf/validate/conformance/cases/filename_with_dash_pb2.py

Lines changed: 1 addition & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/buf/validate/conformance/cases/ignore_empty_proto2_pb2.py

Lines changed: 1 addition & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)