Skip to content

Commit 72b0469

Browse files
Fix sed command in makefile on unix
1 parent 2126f50 commit 72b0469

File tree

12 files changed

+22
-20
lines changed

12 files changed

+22
-20
lines changed

Makefile

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,16 @@ generate: generate-protobuf-tests $(BIN)/license-header ## Regenerate code and
4141

4242
.PHONY: generate-protobuf-tests
4343
generate-protobuf-tests: $(BIN)/buf ## Regenerate protobuf gencode used in unit tests
44-
rm -rf test/gen
44+
#rm -rf test/gen
4545
# generate protovalidate-testing into test/gen/buf/validate
4646
$(BIN)/buf generate buf.build/bufbuild/protovalidate-testing:$(PROTOVALIDATE_TESTING_VERSION)
4747

4848
# generate cel-spec into test/gen/cel/expr
4949
$(BIN)/buf generate buf.build/google/cel-spec:$(CEL_SPEC_VERSION) --exclude-path cel/expr/conformance/proto2 --exclude-path cel/expr/conformance/proto3
5050
# we need to update the `from cel.expr` imports in those generated files to `from test.gen.cel.expr`
51-
LC_ALL=C find test/gen/cel -type f -exec sed -i .bak 's/from cel.expr/from test.gen.cel.expr/g' {} + && find test/gen/cel -name '*.bak' -delete
51+
LC_ALL=C find test/gen/cel -type f -exec sed -i.bak 's/from cel.expr/from test.gen.cel.expr/g' {} + && find test/gen/cel -name '*.bak' -delete
52+
# also update buf.validate.conformance imports
53+
LC_ALL=C find test/gen/buf/validate/conformance -type f -exec sed -i.bak 's/from buf.validate.conformance/from test.gen.buf.validate.conformance/g' {} + && find test/gen/buf/validate/conformance -name '*.bak' -delete
5254

5355
# generate proto/tests/example/v1/validations.proto into test/gen/tests/example/v1
5456
$(BIN)/buf generate
@@ -99,4 +101,4 @@ $(BIN)/license-header: $(BIN) Makefile
99101
go install github.com/bufbuild/buf/private/pkg/licenseheader/cmd/license-header@latest
100102

101103
$(BIN)/protovalidate-conformance: $(BIN) Makefile
102-
go install github.com/bufbuild/protovalidate/tools/protovalidate-conformance@$(PROTOVALIDATE_VERSION)
104+
go install github.com/bufbuild/protovalidate/tools/protovalidate-conformance@$(PROTOVALIDATE_TESTING_VERSION)

test/conformance/runner.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from google.protobuf import any_pb2, descriptor, descriptor_pool, message_factory
2020

2121
import protovalidate
22-
from buf.validate.conformance.cases import (
22+
from test.gen.buf.validate.conformance.cases import (
2323
bool_pb2, # noqa: F401
2424
bytes_pb2, # noqa: F401
2525
enums_pb2, # noqa: F401
@@ -50,8 +50,8 @@
5050
wkt_timestamp_pb2, # noqa: F401
5151
wkt_wrappers_pb2, # noqa: F401
5252
)
53-
from buf.validate.conformance.cases.custom_rules import custom_rules_pb2 # noqa: F401
54-
from buf.validate.conformance.harness import harness_pb2
53+
from test.gen.buf.validate.conformance.cases.custom_rules import custom_rules_pb2 # noqa: F401
54+
from test.gen.buf.validate.conformance.harness import harness_pb2
5555

5656

5757
def run_test_case(tc: typing.Any, result: typing.Optional[harness_pb2.TestResult] = None) -> harness_pb2.TestResult:

test/gen/buf/validate/conformance/cases/enums_pb2.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
_sym_db = _symbol_database.Default()
2727

2828

29-
from buf.validate.conformance.cases.other_package import embed_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_other__package_dot_embed__pb2
30-
from buf.validate.conformance.cases.yet_another_package import embed2_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_yet__another__package_dot_embed2__pb2
29+
from test.gen.buf.validate.conformance.cases.other_package import embed_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_other__package_dot_embed__pb2
30+
from test.gen.buf.validate.conformance.cases.yet_another_package import embed2_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_yet__another__package_dot_embed2__pb2
3131
from buf.validate import validate_pb2 as buf_dot_validate_dot_validate__pb2
3232

3333

test/gen/buf/validate/conformance/cases/enums_pb2.pyi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
from buf.validate.conformance.cases.other_package import embed_pb2 as _embed_pb2
16-
from buf.validate.conformance.cases.yet_another_package import embed2_pb2 as _embed2_pb2
15+
from test.gen.buf.validate.conformance.cases.other_package import embed_pb2 as _embed_pb2
16+
from test.gen.buf.validate.conformance.cases.yet_another_package import embed2_pb2 as _embed2_pb2
1717
from buf.validate import validate_pb2 as _validate_pb2
1818
from google.protobuf.internal import containers as _containers
1919
from google.protobuf.internal import enum_type_wrapper as _enum_type_wrapper

test/gen/buf/validate/conformance/cases/messages_pb2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
_sym_db = _symbol_database.Default()
2727

2828

29-
from buf.validate.conformance.cases.other_package import embed_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_other__package_dot_embed__pb2
29+
from test.gen.buf.validate.conformance.cases.other_package import embed_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_other__package_dot_embed__pb2
3030
from buf.validate import validate_pb2 as buf_dot_validate_dot_validate__pb2
3131

3232

test/gen/buf/validate/conformance/cases/messages_pb2.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
from buf.validate.conformance.cases.other_package import embed_pb2 as _embed_pb2
15+
from test.gen.buf.validate.conformance.cases.other_package import embed_pb2 as _embed_pb2
1616
from buf.validate import validate_pb2 as _validate_pb2
1717
from google.protobuf import descriptor as _descriptor
1818
from google.protobuf import message as _message

test/gen/buf/validate/conformance/cases/predefined_rules_proto3_pb2.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
_sym_db = _symbol_database.Default()
2727

2828

29-
from buf.validate.conformance.cases import predefined_rules_proto2_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_predefined__rules__proto2__pb2
30-
from buf.validate.conformance.cases import predefined_rules_proto_editions_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_predefined__rules__proto__editions__pb2
29+
from test.gen.buf.validate.conformance.cases import predefined_rules_proto2_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_predefined__rules__proto2__pb2
30+
from test.gen.buf.validate.conformance.cases import predefined_rules_proto_editions_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_predefined__rules__proto__editions__pb2
3131
from buf.validate import validate_pb2 as buf_dot_validate_dot_validate__pb2
3232
from google.protobuf import duration_pb2 as google_dot_protobuf_dot_duration__pb2
3333
from google.protobuf import timestamp_pb2 as google_dot_protobuf_dot_timestamp__pb2

test/gen/buf/validate/conformance/cases/predefined_rules_proto3_pb2.pyi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
from buf.validate.conformance.cases import predefined_rules_proto2_pb2 as _predefined_rules_proto2_pb2
16-
from buf.validate.conformance.cases import predefined_rules_proto_editions_pb2 as _predefined_rules_proto_editions_pb2
15+
from test.gen.buf.validate.conformance.cases import predefined_rules_proto2_pb2 as _predefined_rules_proto2_pb2
16+
from test.gen.buf.validate.conformance.cases import predefined_rules_proto_editions_pb2 as _predefined_rules_proto_editions_pb2
1717
from buf.validate import validate_pb2 as _validate_pb2
1818
from google.protobuf import duration_pb2 as _duration_pb2
1919
from google.protobuf import timestamp_pb2 as _timestamp_pb2

test/gen/buf/validate/conformance/cases/repeated_pb2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
_sym_db = _symbol_database.Default()
2727

2828

29-
from buf.validate.conformance.cases.other_package import embed_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_other__package_dot_embed__pb2
29+
from test.gen.buf.validate.conformance.cases.other_package import embed_pb2 as buf_dot_validate_dot_conformance_dot_cases_dot_other__package_dot_embed__pb2
3030
from buf.validate import validate_pb2 as buf_dot_validate_dot_validate__pb2
3131
from google.protobuf import any_pb2 as google_dot_protobuf_dot_any__pb2
3232
from google.protobuf import duration_pb2 as google_dot_protobuf_dot_duration__pb2

test/gen/buf/validate/conformance/cases/repeated_pb2.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
from buf.validate.conformance.cases.other_package import embed_pb2 as _embed_pb2
15+
from test.gen.buf.validate.conformance.cases.other_package import embed_pb2 as _embed_pb2
1616
from buf.validate import validate_pb2 as _validate_pb2
1717
from google.protobuf import any_pb2 as _any_pb2
1818
from google.protobuf import duration_pb2 as _duration_pb2

0 commit comments

Comments
 (0)