Move unit tests to local protos (#288)

The unit tests in this repo use Protobuf definitions from the
conformance suite, which works but it makes debugging issues a bit
difficult. It is extremely helpful to have local protos in the repo that
can be changed for tests to debug issues.

This follows the example in protovalidate-go by creating a
`validations.proto` and copies the definitions currently being used from
conformance into this proto.

Author: smaye81

Makefile

@@ -33,8 +33,9 @@ clean: ## Delete intermediate build artifacts
 .PHONY: generate
 generate: $(BIN)/buf $(BIN)/license-header ## Regenerate code and license headers
 	rm -rf gen
-	buf generate buf.build/bufbuild/protovalidate:$(PROTOVALIDATE_VERSION)
-	buf generate buf.build/bufbuild/protovalidate-testing:$(PROTOVALIDATE_VERSION)
+	$(BIN)/buf generate buf.build/bufbuild/protovalidate:$(PROTOVALIDATE_VERSION)
+	$(BIN)/buf generate buf.build/bufbuild/protovalidate-testing:$(PROTOVALIDATE_VERSION)
+	$(BIN)/buf generate
 	$(ADD_LICENSE_HEADER)
 
 .PHONY: format
@@ -44,7 +45,7 @@ format: install $(BIN)/license-header ## Format code
 	pipenv run ruff check --fix protovalidate tests
 
 .PHONY: test
-test: $(BIN)/protovalidate-conformance generate install ## Run unit tests
+test: generate install ## Run unit tests
 	pipenv run pytest
 
 .PHONY: conformance

buf.lock

@@ -0,0 +1,9 @@
+# Generated by buf. DO NOT EDIT.
+version: v2
+deps:
+  - name: buf.build/bufbuild/protovalidate
+    commit: 0409229c37804d6187ee0806eb4eebce
+    digest: b5:795db9d3a6e066dc61d99ac651fa7f136171869abe2211ca272dd84aada7bc4583b9508249fa5b61300a5b1fe8b6dbf6edbc088aa0345d1ccb9fff705e3d48e9
+  - name: buf.build/bufbuild/protovalidate-testing
+    commit: 5acbe1f3c8f24ced9466b9ccccad4cb0
+    digest: b5:5e9d54d19ce3d9d368f4b1b5ee4f20094d1c33d0f2dca19536339335c2e70d5ffedbd4fa28e290b59ecae0671c9d2dc20b6b8ebba5a9ac76cbf5f9d2af655ef4

buf.yaml

@@ -0,0 +1,15 @@
+version: v2
+modules:
+  - path: proto
+deps:
+  - buf.build/bufbuild/protovalidate
+  - buf.build/bufbuild/protovalidate-testing
+lint:
+  use:
+    - STANDARD
+  ignore_only:
+    PROTOVALIDATE:
+      - proto/tests/example/v1/validations.proto
+breaking:
+  use:
+    - FILE

gen/tests/example/v1/validations_pb2.py

@@ -0,0 +1,65 @@
+// Copyright 2023-2025 Buf Technologies, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+syntax = "proto3";
+
+package tests.example.v1;
+
+import "buf/validate/validate.proto";
+import "google/protobuf/timestamp.proto";
+
+message DoubleFinite {
+  double val = 1 [(buf.validate.field).double.finite = true];
+}
+
+message SFixed64ExLTGT {
+  sfixed64 val = 1 [(buf.validate.field).sfixed64 = {
+    lt: 0
+    gt: 10
+  }];
+}
+
+message TestOneofMsg {
+  bool val = 1 [(buf.validate.field).bool.const = true];
+}
+
+message Oneof {
+  oneof o {
+    string x = 1 [(buf.validate.field).string.prefix = "foo"];
+    int32 y = 2 [(buf.validate.field).int32.gt = 0];
+    TestOneofMsg z = 3;
+  }
+}
+
+message TimestampGTNow {
+  google.protobuf.Timestamp val = 1 [(buf.validate.field).timestamp.gt_now = true];
+}
+
+message MapMinMax {
+  map<string, bool> val = 1 [(buf.validate.field).map = {
+    min_pairs: 2
+    max_pairs: 4
+  }];
+}
+
+message MapKeys {
+  map<sint64, string> val = 1 [(buf.validate.field).map.keys.sint64.lt = 0];
+}
+
+message Embed {
+  int64 val = 1 [(buf.validate.field).int64.gt = 0];
+}
+message RepeatedEmbedSkip {
+  repeated Embed val = 1 [(buf.validate.field).repeated.items.ignore = IGNORE_ALWAYS];
+}

gen/tests/example/v1/validations_pb2.pyi

@@ -15,12 +15,12 @@
 import unittest
 
 import protovalidate
-from buf.validate.conformance.cases import maps_pb2, numbers_pb2, oneofs_pb2, repeated_pb2, wkt_timestamp_pb2
+from gen.tests.example.v1 import validations_pb2
 
 
 class TestValidate(unittest.TestCase):
     def test_ninf(self):
-        msg = numbers_pb2.DoubleFinite()
+        msg = validations_pb2.DoubleFinite()
         msg.val = float("-inf")
         violations = protovalidate.collect_violations(msg)
         self.assertEqual(len(violations), 1)
@@ -29,7 +29,7 @@ def test_ninf(self):
         self.assertEqual(violations[0].rule_value, True)
 
     def test_map_key(self):
-        msg = maps_pb2.MapKeys()
+        msg = validations_pb2.MapKeys()
         msg.val[1] = "a"
         violations = protovalidate.collect_violations(msg)
         self.assertEqual(len(violations), 1)
@@ -38,18 +38,18 @@ def test_map_key(self):
         self.assertEqual(violations[0].rule_value, 0)
 
     def test_sfixed64(self):
-        msg = numbers_pb2.SFixed64ExLTGT(val=11)
+        msg = validations_pb2.SFixed64ExLTGT(val=11)
         protovalidate.validate(msg)
 
         violations = protovalidate.collect_violations(msg)
         self.assertEqual(len(violations), 0)
 
     def test_oneofs(self):
-        msg1 = oneofs_pb2.Oneof()
+        msg1 = validations_pb2.Oneof()
         msg1.y = 123
         protovalidate.validate(msg1)
 
-        msg2 = oneofs_pb2.Oneof()
+        msg2 = validations_pb2.Oneof()
         msg2.z.val = True
         protovalidate.validate(msg2)
 
@@ -58,15 +58,15 @@ def test_oneofs(self):
         assert len(violations) == 0
 
     def test_repeated(self):
-        msg = repeated_pb2.RepeatedEmbedSkip()
+        msg = validations_pb2.RepeatedEmbedSkip()
         msg.val.add(val=-1)
         protovalidate.validate(msg)
 
         violations = protovalidate.collect_violations(msg)
         assert len(violations) == 0
 
     def test_maps(self):
-        msg = maps_pb2.MapMinMax()
+        msg = validations_pb2.MapMinMax()
         try:
             protovalidate.validate(msg)
         except protovalidate.ValidationError as e:
@@ -78,7 +78,7 @@ def test_maps(self):
         assert len(violations) == 1
 
     def test_timestamp(self):
-        msg = wkt_timestamp_pb2.TimestampGTNow()
+        msg = validations_pb2.TimestampGTNow()
         protovalidate.validate(msg)
 
         violations = protovalidate.collect_violations(msg)