Remove/fix noqa usages

* Passes a boolean as a kwarg
* Removes unnecessary mutable vars (defined in __init__)
* Remove unused "exported" vars

Author: stefanvanburen

protovalidate/internal/constraints.py

@@ -247,7 +247,7 @@ def __init__(self, *, field_value: typing.Any = None, rule_value: typing.Any = N
 class ConstraintContext:
     """The state associated with a single constraint evaluation."""
 
-    def __init__(self, fail_fast: bool = False, violations: typing.Optional[list[Violation]] = None):  # noqa: FBT001, FBT002
+    def __init__(self, *, fail_fast: bool = False, violations: typing.Optional[list[Violation]] = None):
         self._fail_fast = fail_fast
         if violations is None:
             violations = []
@@ -283,13 +283,13 @@ def has_errors(self) -> bool:
         return len(self._violations) > 0
 
     def sub_context(self):
-        return ConstraintContext(self._fail_fast)
+        return ConstraintContext(fail_fast=self._fail_fast)
 
 
 class ConstraintRules:
     """The constraints associated with a single 'rules' message."""
 
-    def validate(self, ctx: ConstraintContext, message: message.Message):  # noqa: ARG002
+    def validate(self, ctx: ConstraintContext, _: message.Message):
         """Validate the message against the rules in this constraint."""
         ctx.add(Violation(constraint_id="unimplemented", message="Unimplemented"))
 
@@ -541,9 +541,6 @@ def _validate_value(self, ctx: ConstraintContext, val: typing.Any, *, for_key: b
 class AnyConstraintRules(FieldConstraintRules):
     """Rules for an Any field."""
 
-    _in: list[str] = []  # noqa: RUF012
-    _not_in: list[str] = []  # noqa: RUF012
-
     _in_rule_path: typing.ClassVar[validate_pb2.FieldPath] = validate_pb2.FieldPath(
         elements=[
             _field_to_element(validate_pb2.AnyRules.DESCRIPTOR.fields_by_number[validate_pb2.AnyRules.IN_FIELD_NUMBER]),
@@ -576,8 +573,10 @@ def __init__(
         field_level: validate_pb2.FieldConstraints,
     ):
         super().__init__(env, funcs, field, field_level)
+        self._in = []
         if getattr(field_level.any, "in"):
             self._in = getattr(field_level.any, "in")
+        self._not_in = []
         if field_level.any.not_in:
             self._not_in = field_level.any.not_in
 

protovalidate/internal/string_format.py

@@ -190,8 +190,3 @@ def format_list(self, arg: celtypes.ListType) -> celpy.Result:
 
     def _format_duration(self, arg: celtypes.DurationType) -> celpy.Result:
         return f"{arg.seconds + Decimal(arg.microseconds) / Decimal(1_000_000):f}s"
-
-
-_default_format = StringFormat("en_US")
-format = _default_format.format  # noqa: A001
-format_value = _default_format.format_value