Skip to content

Fully test and fix types in StringFormat implementation #257

@stefanvanburen

Description

@stefanvanburen

Our current StringFormat implementation is balking at the cel-python types we're using. Additionally, the protovalidate-conformance suite only really tests the %s verb, so we ought to have tests over the rest of the verbs.

The cel-spec test suite for formatting can be found here: https://github.com/google/cel-spec/blob/master/tests/simple/testdata/string_ext.textproto. Here is cel-go's explanation of how format should work.

Additionally, while we currently can add these tests in-repo, it'd behoove us to contribute a conformant implementation upstream to cel-python.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions