(es)lint: fixes

Author: christogav

package-lock.json

@@ -66,7 +66,7 @@ export const findBuf = new Command(
 );
 
 const findBufInPath = async (): Promise<BufVersion | null> => {
-  let bufPath = await which(bufFilename, { nothrow: true });
+  const bufPath = await which(bufFilename, { nothrow: true });
 
   if (bufPath) {
     return BufVersion.fromPath(bufPath);

src/commands/find-buf.ts

@@ -1,35 +1,30 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import * as vscode from "vscode";
 
 import { BufContext } from "../context";
 
-type CommandCallback<T extends unknown = any> = (
-  ...args: any
-) => Promise<T> | T;
+type CommandCallback<T = any> = (...args: any) => Promise<T> | T;
 
-export type CommandFactory<T extends unknown = any> = (
+export type CommandFactory<T = any> = (
   ctx: vscode.ExtensionContext,
   bufCtx: BufContext
 ) => CommandCallback<T>;
 
 export enum CommandType {
   // Commands to run buf commands e.g. generate
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   COMMAND_BUF,
 
   // Extension commands
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   COMMAND_EXTENSION,
 
   // Commands to setup the extension e.g. install buf
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   COMMAND_SETUP,
 
   // Internal commands. Note: these are not registered in the command palette
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   COMMAND_INTERNAL,
 }
 
-export class Command<T extends unknown = any> {
+export class Command<T = any> {
   constructor(
     public readonly command: string,
     public readonly type: CommandType,

src/commands/index.ts

@@ -35,7 +35,7 @@ export const installBuf = new Command(
         const release = await github.latestRelease();
         const asset = await github.findAsset(release);
 
-        var bufPath = await install(ctx, release, asset, abort);
+        const bufPath = await install(ctx, release, asset, abort);
 
         bufCtx.buf = await BufVersion.fromPath(bufPath);
         vscode.window.showInformationMessage(
@@ -76,7 +76,9 @@ export const install = async (
 
     // If we made it to this point, the binary is valid, reuse it.
     return downloadBin;
-  } catch {}
+  } catch {
+    // Ignore errors, we will download it.
+  }
 
   // If we've fallen out here.. lets proceed to download.
   log.info(`Downloading ${asset.name} to ${downloadBin}...`);

src/commands/install-buf.ts

@@ -51,7 +51,7 @@ export const restartBuf = new Command(
 
       const traceFile = config.get<string>("trace");
 
-      if (!!traceFile) {
+      if (traceFile) {
         const trace = { BUF_TRACE: traceFile };
         buf.options = { env: { ...process.env, ...trace } };
       }
@@ -107,7 +107,7 @@ export const restartBuf = new Command(
 );
 
 const getBufArgs = () => {
-  let bufArgs = config.get<string[]>("arguments");
+  const bufArgs = config.get<string[]>("arguments");
 
   if (config.get<string>("debug")) {
     bufArgs.push("--debug");

src/commands/restart-buf.ts

@@ -10,11 +10,15 @@ export const showCommands = new Command(
   "buf.showCommands",
   CommandType.COMMAND_EXTENSION,
   () => {
-    let quickPickList: BufQuickPickItem[] = [];
+    const quickPickList: BufQuickPickItem[] = [];
 
     const pkgJSON = vscode.extensions.getExtension(extensionId)?.packageJSON;
     if (pkgJSON.contributes && pkgJSON.contributes.commands) {
-      const commands: any[] = pkgJSON.contributes.commands;
+      const commands: {
+        command: string;
+        title: string;
+        description: string;
+      }[] = pkgJSON.contributes.commands;
       const bufCommands: BufQuickPickItem[] = [];
       const extCommands: BufQuickPickItem[] = [];
       const setupCommands: BufQuickPickItem[] = [];

src/commands/show-commands.ts

@@ -5,7 +5,7 @@ import * as github from "../github";
 import { Command, CommandType, loadBufModules, restartBuf } from ".";
 import { install } from "./install-buf";
 import { log } from "../util";
-import { BufVersion } from "../version";
+import { BufVersion, Upgrade } from "../version";
 
 export const updateBuf = new Command(
   "buf.update",
@@ -17,12 +17,16 @@ export const updateBuf = new Command(
         return;
       }
 
+      let release: github.Release;
+      let asset: github.Asset;
+      let upgrade: Upgrade;
+
       // Gather all the version information to see if there's an upgrade.
       try {
         log.info("Checking for buf update...");
-        var release = await github.latestRelease();
-        var asset = await github.findAsset(release); // Ensure a binary for this platform.
-        var upgrade = await bufCtx.buf?.hasUpgrade(release);
+        release = await github.latestRelease();
+        asset = await github.findAsset(release); // Ensure a binary for this platform.
+        upgrade = await bufCtx.buf?.hasUpgrade(release);
       } catch (e) {
         log.info(`Failed to check for buf update: ${e}`);
 

src/commands/update-buf.ts

@@ -28,8 +28,9 @@ function substitute<T>(val: T): T {
     val = val.map((x) => substitute(x)) as unknown as T;
   } else if (typeof val === "object" && val !== null) {
     // Substitute values but not keys, so we don't deal with collisions.
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const result = {} as { [k: string]: any };
-    for (let [k, v] of Object.entries(val)) {
+    for (const [k, v] of Object.entries(val)) {
       result[k] = substitute(v);
     }
     val = result as T;

src/config.ts

@@ -8,15 +8,10 @@ export type BufFile = {
 };
 
 export enum ServerStatus {
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   SERVER_DISABLED,
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   SERVER_STARTING,
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   SERVER_RUNNING,
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   SERVER_STOPPED,
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   SERVER_ERRORED,
 }
 

src/context.ts

@@ -6,7 +6,7 @@ import * as status from "./status";
 import { BufContext, ServerStatus } from "./context";
 import { log } from "./util";
 
-let bufCtx = new BufContext();
+const bufCtx = new BufContext();
 
 export async function activate(ctx: vscode.ExtensionContext) {
   status.activate(ctx, bufCtx);