Skip to content

Commit f8547ac

Browse files
committed
Disable playwright tests when buf is not installed on system $PATH
1 parent e416567 commit f8547ac

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/workflows/build.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,11 @@ jobs:
5050
run: npm run test:playwright
5151
# Limiting playwright tests to macOS for now due to issues with xvfb on Linux and
5252
# timeouts on windows
53-
if: runner.os == 'macOS'
53+
#
54+
# NOTE: We disable playwright tests when buf is not installed on the system $PATH
55+
# for now so we don't have the extension attempting to resolve the installation.
56+
# We'll need to find a way to intercept the call from playwright's VS Code extension.
57+
if: runner.os == 'macOS' && matrix.buf-bin=setup == 'buf-on-path'
5458
- name: check diff
5559
run: node scripts/gh-diffcheck.mjs
5660
- name: upload-playwright-test-results

0 commit comments

Comments
 (0)