Conversation
doriable
reviewed
Oct 23, 2024
doriable
reviewed
Nov 18, 2024
doriable
reviewed
Nov 21, 2024
| if (platform instanceof Error) { | ||
| return platform; | ||
| } | ||
| let name = `buf-${platform}.tar.gz`; |
Member
There was a problem hiding this comment.
We need a special case for windows where we look for the .exe file instead of the tarball.
Contributor
|
I've been running this branch (on osx) for a few months now and is working very well. Would love to see this merged. Can I help with any further changes required? @mcy |
Merged
doriable
pushed a commit
that referenced
this pull request
May 21, 2025
Hi team, I've spent the last couple weekends looking at #344 which appears abandoned. This snowballed a bit into a rewrite for mostly maintainability and testability reasons. Apologies for the size of the pull - happy to split it up if you want to take it on, else I'll continue happily running this locally. Changes I've introduced: - Introduce a command pattern for command handling. - Rewrite installation processes via install/update commands (now works cross platform). - Provide flexible method of using buf located in path/storage. - Improve status bar with a command picker. - Support 'buf generate' as a command. - ~~Support module detection for the active file in editor.~~ - ~~Provide a shortcut to opening 'buf.yaml' as a command.~~ --------- Co-authored-by: Paul Sachs <psachs@buf.build>
Member
|
Closing this, as it has been superseded by more recent PRs #392 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bufbuild/buf#3316