Skip to content

Commit 40b1d1d

Browse files
committed
Require strings for checkbox dailog
1 parent b127508 commit 40b1d1d

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ publish {
3636
userOrg = 'buffer'
3737
groupId = 'org.buffer.android'
3838
artifactId = 'android-components'
39-
publishVersion = '0.17'
39+
publishVersion = '0.18'
4040
desc = 'An Android library for frequently used UI components'
4141
website = 'https://github.com/bufferapp/android-components'
4242
}

app/src/main/java/org/buffer/android/components/DialogFactory.kt

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -373,32 +373,31 @@ object DialogFactory {
373373
}
374374

375375
fun createCheckboxDialog(
376-
context: Context,
377-
@StringRes title: Int,
378-
@StringRes message: Int,
379-
@StringRes positive: Int,
380-
@StringRes neutral: Int?,
381-
@StringRes checkbox: Int,
382-
clickListener: ActionListener? = null
376+
context: Context,
377+
title: String,
378+
message: String,
379+
positive: String,
380+
neutral: String?,
381+
checkbox: String,
382+
clickListener: ActionListener? = null
383383
): MaterialAlertDialogBuilder {
384384
val checkboxView = LayoutInflater.from(context).inflate(R.layout.checkbox, null)
385385
val dontShowAgain = checkboxView.findViewById<CheckBox>(R.id.skip)
386-
dontShowAgain.setText(checkbox)
386+
dontShowAgain.text = checkbox
387387

388388
val builder = MaterialAlertDialogBuilder(context)
389-
.setView(checkboxView)
390-
.setTitle(title)
391-
.setMessage(message)
392-
.setPositiveButton(positive) { dialog, which ->
393-
clickListener?.onPositiveButtonSelected(dontShowAgain.isChecked) }
389+
.setView(checkboxView)
390+
.setTitle(title)
391+
.setMessage(message)
392+
.setPositiveButton(positive) { _, _ ->
393+
clickListener?.onPositiveButtonSelected(dontShowAgain.isChecked) }
394394
if (neutral != null) {
395-
builder.setNeutralButton(neutral) { dialog, which ->
395+
builder.setNeutralButton(neutral) { _, _ ->
396396
clickListener?.onNeutralButtonSelected(dontShowAgain.isChecked) }
397397
}
398398
return builder
399399
}
400400

401-
402401
interface InputListener {
403402
fun onTextInput(text: String)
404403
}

0 commit comments

Comments
 (0)