fix(lsp): inlay hints now based on lock file version (#52)

Shows ✅ only when lock file has the latest version.
Shows ❌ otherwise, regardless of manifest requirement.

Author: bug-ops

CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.5.4] - 2026-01-15
+
+### Fixed
+- **Inlay hints now based on lock file version** — Shows ✅ only when lock file has the latest version, ❌ otherwise (regardless of manifest requirement)
+
 ## [0.5.3] - 2026-01-15
 
 ### Changed

Cargo.toml

@@ -4,7 +4,7 @@ exclude = ["crates/deps-zed"]
 resolver = "2"
 
 [workspace.package]
-version = "0.5.3"
+version = "0.5.4"
 edition = "2024"
 rust-version = "1.89"
 authors = ["Andrei G"]
@@ -15,12 +15,12 @@ repository = "https://github.com/bug-ops/deps-lsp"
 async-trait = "0.1"
 criterion = "0.8"
 dashmap = "6.1"
-deps-core = { version = "0.5.3", path = "crates/deps-core" }
-deps-cargo = { version = "0.5.3", path = "crates/deps-cargo" }
-deps-npm = { version = "0.5.3", path = "crates/deps-npm" }
-deps-pypi = { version = "0.5.3", path = "crates/deps-pypi" }
-deps-go = { version = "0.5.3", path = "crates/deps-go" }
-deps-lsp = { version = "0.5.3", path = "crates/deps-lsp" }
+deps-core = { version = "0.5.4", path = "crates/deps-core" }
+deps-cargo = { version = "0.5.4", path = "crates/deps-cargo" }
+deps-npm = { version = "0.5.4", path = "crates/deps-npm" }
+deps-pypi = { version = "0.5.4", path = "crates/deps-pypi" }
+deps-go = { version = "0.5.4", path = "crates/deps-go" }
+deps-lsp = { version = "0.5.4", path = "crates/deps-lsp" }
 futures = "0.3"
 insta = "1"
 mockito = "1"

crates/deps-cargo/src/ecosystem.rs

@@ -358,7 +358,9 @@ mod tests {
             needs_update_text: "❌ {}".to_string(),
         };
 
-        let resolved_versions = HashMap::new();
+        // Lock file has the latest version
+        let mut resolved_versions = HashMap::new();
+        resolved_versions.insert("serde".to_string(), "1.0.214".to_string());
         let hints = tokio_test::block_on(ecosystem.generate_inlay_hints(
             &parse_result,
             &cached_versions,
@@ -369,7 +371,7 @@ mod tests {
 
         assert_eq!(hints.len(), 1);
         match &hints[0].label {
-            InlayHintLabel::String(s) => assert_eq!(s, "✅"),
+            InlayHintLabel::String(s) => assert_eq!(s, "✅ 1.0.214"),
             _ => panic!("Expected String label"),
         }
     }
@@ -394,7 +396,9 @@ mod tests {
             needs_update_text: "❌ {}".to_string(),
         };
 
-        let resolved_versions = HashMap::new();
+        // Lock file has the latest version
+        let mut resolved_versions = HashMap::new();
+        resolved_versions.insert("serde".to_string(), "1.0.214".to_string());
         let hints = tokio_test::block_on(ecosystem.generate_inlay_hints(
             &parse_result,
             &cached_versions,
@@ -405,7 +409,7 @@ mod tests {
 
         assert_eq!(hints.len(), 1);
         match &hints[0].label {
-            InlayHintLabel::String(s) => assert_eq!(s, "✅"),
+            InlayHintLabel::String(s) => assert_eq!(s, "✅ 1.0.214"),
             _ => panic!("Expected String label"),
         }
     }
@@ -466,7 +470,9 @@ mod tests {
             needs_update_text: "❌ {}".to_string(),
         };
 
-        let resolved_versions = HashMap::new();
+        // Lock file has the latest version - but show_up_to_date_hints is false
+        let mut resolved_versions = HashMap::new();
+        resolved_versions.insert("serde".to_string(), "1.0.214".to_string());
         let hints = tokio_test::block_on(ecosystem.generate_inlay_hints(
             &parse_result,
             &cached_versions,

crates/deps-core/src/lsp_helpers.rs

@@ -172,11 +172,9 @@ pub fn generate_inlay_hints(
             continue;
         };
 
-        let version_req = dep.version_requirement().unwrap_or("");
-        let requirement_allows_latest =
-            formatter.version_satisfies_requirement(latest, version_req);
-
-        let (is_up_to_date, display_version) = (requirement_allows_latest, Some(latest.as_str()));
+        // Up-to-date only if lock file already has the latest version
+        let is_up_to_date =
+            resolved_version.is_some_and(|resolved| resolved.as_str() == latest.as_str());
 
         let label_text = if is_up_to_date {
             if config.show_up_to_date_hints {
@@ -189,8 +187,7 @@ pub fn generate_inlay_hints(
                 continue;
             }
         } else {
-            let version = display_version.unwrap_or("unknown");
-            config.needs_update_text.replace("{}", version)
+            config.needs_update_text.replace("{}", latest)
         };
 
         hints.push(InlayHint {
@@ -1141,7 +1138,9 @@ mod tests {
         let mut cached_versions = HashMap::new();
         cached_versions.insert("serde".to_string(), "1.0.214".to_string());
 
-        let resolved_versions = HashMap::new();
+        // Lock file has the latest version
+        let mut resolved_versions = HashMap::new();
+        resolved_versions.insert("serde".to_string(), "1.0.214".to_string());
 
         let hints = generate_inlay_hints(
             &parse_result,
@@ -1156,7 +1155,7 @@ mod tests {
         match &hints[0].label {
             InlayHintLabel::String(text) => {
                 assert_eq!(
-                    text, "✅",
+                    text, "✅ 1.0.214",
                     "Expected up-to-date hint, not loading hint, got: {}",
                     text
                 );

crates/deps-go/src/ecosystem.rs

@@ -310,7 +310,9 @@ mod tests {
             needs_update_text: "❌ {}".to_string(),
         };
 
-        let resolved_versions = HashMap::new();
+        // Lock file has the latest version
+        let mut resolved_versions = HashMap::new();
+        resolved_versions.insert("github.com/gin-gonic/gin".to_string(), "v1.9.1".to_string());
         let hints = tokio_test::block_on(ecosystem.generate_inlay_hints(
             &parse_result,
             &cached_versions,
@@ -321,7 +323,7 @@ mod tests {
 
         assert_eq!(hints.len(), 1);
         match &hints[0].label {
-            InlayHintLabel::String(s) => assert_eq!(s, "✅"),
+            InlayHintLabel::String(s) => assert_eq!(s, "✅ v1.9.1"),
             _ => panic!("Expected String label"),
         }
     }
@@ -394,7 +396,9 @@ mod tests {
             needs_update_text: "❌ {}".to_string(),
         };
 
-        let resolved_versions = HashMap::new();
+        // Lock file has the latest version - but show_up_to_date_hints is false
+        let mut resolved_versions = HashMap::new();
+        resolved_versions.insert("github.com/gin-gonic/gin".to_string(), "v1.9.1".to_string());
         let hints = tokio_test::block_on(ecosystem.generate_inlay_hints(
             &parse_result,
             &cached_versions,