ci: enforce clippy warnings as errors in CI

Changes:
- Changed workspace lints from warn to deny for all clippy categories
  (all, pedantic, cargo, nursery) to enforce code quality in CI
- Fixed clippy warnings in test code:
  - significant_drop_tightening: Explicit lock drop in mcp-introspector
  - case_sensitive_file_extension_comparisons: Use Path API in mcp-codegen
  - float_cmp: Use epsilon comparison in mcp-wasm-runtime
  - needless_collect: Use iterator directly in mcp-examples
  - branches_sharing_code: Refactor shared return in mcp-examples
  - unnecessary_map_or: Use is_some_and in mcp-codegen
- Added too_many_lines to allowed lints for comprehensive examples/tests
- Removed redundant clippy warn directives from mcp-skill-generator

All 501 tests passing. Clippy clean with exit code 0.

Author: bug-ops

Cargo.toml

@@ -121,16 +121,17 @@ unsafe_op_in_unsafe_fn = "deny"
 unused_lifetimes = "warn"
 
 [workspace.lints.clippy]
-# Note: Temporarily relaxed for Phase 7.1 - will be re-enabled in follow-up
-all = { level = "warn", priority = -1 }
-pedantic = { level = "warn", priority = -1 }
-cargo = { level = "warn", priority = -1 }
-nursery = { level = "warn", priority = -1 }
+# Deny all clippy warnings by default to enforce code quality in CI
+all = { level = "deny", priority = -1 }
+pedantic = { level = "deny", priority = -1 }
+cargo = { level = "deny", priority = -1 }
+nursery = { level = "deny", priority = -1 }
 
 # Allow specific lints that are too strict or have false positives
 needless_borrows_for_generic_args = { level = "allow", priority = 10 }
 multiple_crate_versions = { level = "allow", priority = 10 }           # Common with transitive dependencies
 cargo_common_metadata = { level = "allow", priority = 10 }             # Not required for internal workspace crates
+too_many_lines = { level = "allow", priority = 10 }                    # Allow comprehensive examples and tests
 
 [profile.release]
 opt-level = 3

crates/mcp-codegen/tests/integration_test.rs

@@ -310,7 +310,11 @@ fn test_generated_typescript_is_syntactically_valid() {
     let generated = generator.generate(&server_info).unwrap();
 
     for file in &generated.files {
-        if file.path.ends_with(".ts") {
+        if std::path::Path::new(&file.path)
+            .extension()
+            .and_then(|ext| ext.to_str())
+            .is_some_and(|ext| ext.eq_ignore_ascii_case("ts"))
+        {
             // Basic TypeScript syntax checks
             let content = &file.content;
 

crates/mcp-examples/examples/performance_test.rs

@@ -304,13 +304,12 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     // Exit with appropriate code
     if passed == total {
         println!("Performance test: SUCCESS\n");
-        Ok(())
     } else {
         println!("Performance test: PARTIAL (some targets missed)\n");
         println!("Note: This is acceptable for development builds.");
         println!("      Run with --release for production performance.\n");
-        Ok(())
     }
+    Ok(())
 }
 
 /// Creates a minimal demo WASM module for testing.

crates/mcp-examples/tests/integration_test.rs

@@ -114,13 +114,11 @@ fn test_codegen_generates_expected_files() {
     assert!(has_types, "Should generate types.ts");
 
     // Should generate tool files
-    let tool_files: Vec<_> = generated
-        .files
-        .iter()
-        .filter(|f| f.path.contains("tools/"))
-        .collect();
     assert!(
-        !tool_files.is_empty(),
+        generated
+            .files
+            .iter()
+            .any(|f| f.path.contains("tools/")),
         "Should generate tool implementation files"
     );
 }

crates/mcp-introspector/tests/integration_test.rs

@@ -226,10 +226,9 @@ async fn test_concurrent_introspector_access() {
     for i in 0..10 {
         let introspector_clone = Arc::clone(&introspector);
         let handle = tokio::spawn(async move {
-            {
-                let intro = introspector_clone.lock().await;
-                assert_eq!(intro.server_count(), 0);
-            }
+            let intro = introspector_clone.lock().await;
+            assert_eq!(intro.server_count(), 0);
+            drop(intro); // Explicitly drop lock before returning
             i
         });
         handles.push(handle);

crates/mcp-skill-generator/src/lib.rs

@@ -125,9 +125,6 @@
 //! Tokio and multi-threaded environments.
 
 #![warn(missing_docs)]
-#![warn(clippy::all)]
-#![warn(clippy::pedantic)]
-#![warn(clippy::cargo)]
 
 pub mod skill_template;
 pub mod types;

crates/mcp-wasm-runtime/tests/performance_test.rs

@@ -373,5 +373,5 @@ fn test_cache_statistics() {
     let (hits, total, rate) = cache.hit_rate();
     assert_eq!(hits, 5);
     assert_eq!(total, 10);
-    assert_eq!(rate, 50.0); // 5/10 = 50%
+    assert!((rate - 50.0).abs() < f64::EPSILON); // 5/10 = 50%
 }