Skip to content

Commit 1c0a856

Browse files
authored
Revert faraday and upgrade to Ruby 3.2
2 parents 9b1a32f + 08fc3b8 commit 1c0a856

File tree

9 files changed

+42
-20
lines changed

9 files changed

+42
-20
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ jobs:
1414
name: Ruby ${{ matrix.ruby }}
1515
strategy:
1616
matrix:
17-
ruby: [2.6, 2.7, 3.0, 3.1]
17+
ruby: [3.2]
1818
steps:
1919
- name: Check out code
20-
uses: actions/checkout@v2
20+
uses: actions/checkout@v4
2121
- name: Set up Ruby ${{ matrix.ruby }}
2222
uses: ruby/setup-ruby@v1
2323
with:

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.7.2
1+
3.2.2

.tool-versions

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ruby 3.2.2

CHANGELOG.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
# Changelog
22

3-
## [v1.0.0] - 2023-07-12
4-
- [Upgrade to Faraday 2.x](https://github.com/Shopify/oktakit/pull/68)
5-
63
## [v0.3.3] - 2022-07-20
74
- [Loosen sawyer dependency to allow 0.9.1](https://github.com/Shopify/oktakit/pull/61)
85

Gemfile.lock

Lines changed: 30 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,46 @@
11
PATH
22
remote: .
33
specs:
4-
oktakit (1.0.0)
5-
faraday (>= 2.0.1, < 3)
4+
oktakit (0.3.3)
5+
faraday (>= 0.17.3, < 2)
66
sawyer (>= 0.8.1, < 0.10)
77

88
GEM
99
remote: https://rubygems.org/
1010
specs:
11-
addressable (2.8.4)
12-
public_suffix (>= 2.0.2, < 6.0)
11+
addressable (2.8.0)
12+
public_suffix (>= 2.0.2, < 5.0)
1313
ast (2.4.2)
1414
byebug (11.1.3)
1515
diff-lcs (1.4.4)
16-
faraday (2.7.10)
17-
faraday-net_http (>= 2.0, < 3.1)
16+
faraday (1.10.0)
17+
faraday-em_http (~> 1.0)
18+
faraday-em_synchrony (~> 1.0)
19+
faraday-excon (~> 1.1)
20+
faraday-httpclient (~> 1.0)
21+
faraday-multipart (~> 1.0)
22+
faraday-net_http (~> 1.0)
23+
faraday-net_http_persistent (~> 1.0)
24+
faraday-patron (~> 1.0)
25+
faraday-rack (~> 1.0)
26+
faraday-retry (~> 1.0)
1827
ruby2_keywords (>= 0.0.4)
19-
faraday-net_http (3.0.2)
28+
faraday-em_http (1.0.0)
29+
faraday-em_synchrony (1.0.0)
30+
faraday-excon (1.1.0)
31+
faraday-httpclient (1.0.1)
32+
faraday-multipart (1.0.4)
33+
multipart-post (~> 2)
34+
faraday-net_http (1.0.1)
35+
faraday-net_http_persistent (1.2.0)
36+
faraday-patron (1.0.0)
37+
faraday-rack (1.0.0)
38+
faraday-retry (1.0.3)
39+
multipart-post (2.2.3)
2040
parallel (1.21.0)
2141
parser (3.0.3.2)
2242
ast (~> 2.4.1)
23-
public_suffix (5.0.3)
43+
public_suffix (4.0.7)
2444
rainbow (3.0.0)
2545
rake (13.0.6)
2646
regexp_parser (2.2.0)
@@ -63,6 +83,7 @@ GEM
6383
PLATFORMS
6484
-darwin-21
6585
arm64-darwin-21
86+
arm64-darwin-24
6687
x86_64-linux
6788

6889
DEPENDENCIES
@@ -77,4 +98,4 @@ DEPENDENCIES
7798
yard
7899

79100
BUNDLED WITH
80-
2.3.24
101+
2.2.22

lib/oktakit/client.rb

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,13 @@ class Client
2424
include Templates
2525
include Users
2626

27+
# In Faraday 0.9, Faraday::Builder was renamed to Faraday::RackBuilder
28+
RACK_BUILDER_CLASS = defined?(Faraday::RackBuilder) ? Faraday::RackBuilder : Faraday::Builder
29+
2730
# Default Faraday middleware stack
28-
MIDDLEWARE = Faraday::RackBuilder.new do |builder|
31+
MIDDLEWARE = RACK_BUILDER_CLASS.new do |builder|
2932
builder.use(Oktakit::Response::RaiseError)
30-
builder.adapter(:net_http)
33+
builder.adapter(Faraday.default_adapter)
3134
end
3235

3336
def initialize(token: nil, access_token: nil, organization: nil, api_endpoint: nil)

lib/oktakit/response/raise_error.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Oktakit
66
module Response
77
# This class raises an Oktakit-flavored exception based
88
# HTTP status codes returned by the API
9-
class RaiseError < Faraday::Middleware
9+
class RaiseError < Faraday::Response::Middleware
1010
private
1111

1212
def on_complete(response)

lib/oktakit/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module Oktakit
2-
VERSION = '1.0.0'.freeze
2+
VERSION = '0.3.3'.freeze
33
end

oktakit.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ Gem::Specification.new do |spec|
2020
spec.required_ruby_version = '>= 2.6'
2121

2222
spec.add_dependency('sawyer', '>= 0.8.1', '< 0.10')
23-
spec.add_dependency('faraday', '>= 2.0.1', '< 3')
23+
spec.add_dependency('faraday', '>= 0.17.3', '< 2')
2424
spec.add_development_dependency('bundler')
2525
end

0 commit comments

Comments
 (0)