Change fetch to dig to return nil instead of false (#4)

Author: adamrdavid

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    vrt (0.2.0)
+    vrt (0.2.1)
 
 GEM
   remote: https://rubygems.org/

lib/vrt/map.rb

@@ -63,7 +63,7 @@ def walk_node_tree(string, max_depth: 'variant')
 
     def search(ids, node, level)
       last_level = level.eql?(ids.length)
-      last_level ? node : node&.children&.fetch(ids[level], false)
+      last_level ? node : node&.children&.dig(ids[level])
     end
 
     def build_structure

lib/vrt/version.rb

@@ -1,3 +1,3 @@
 module Vrt
-  VERSION = '0.2.0'.freeze
+  VERSION = '0.2.1'.freeze
 end

spec/sample_vrt/2.0/vulnerability-rating-taxonomy.json

@@ -160,6 +160,25 @@
       "type": "category",
       "priority": 4,
       "children": []
+    },
+    {
+      "id": "insecure_data_storage",
+      "name": "insecure_data_storage",
+      "type": "category",
+      "children": [
+        {
+          "id": "insecure_data_storage",
+          "name": "insecure_data_storage",
+          "type": "subcategory",
+          "children": [
+            {
+              "id": "password",
+              "name": "password",
+              "type": "variant"
+            }
+          ]
+        }
+      ]
     }
   ]
 }

spec/sample_vrt/999.999/vulnerability-rating-taxonomy.json

@@ -1315,19 +1315,6 @@
           "name": "Screen Caching Enabled",
           "type": "subcategory",
           "priority": 5
-        },
-        {
-          "id": "insecure_data_storage",
-          "name": "Insecure Data Storage",
-          "type": "subcategory",
-          "children": [
-            {
-              "id": "password",
-              "name": "Password",
-              "type": "variant",
-              "priority": 2
-            }
-          ]
         }
       ]
     },

spec/vrt_spec.rb

@@ -148,6 +148,15 @@
         end
       end
 
+      context 'has valid parent two levels up' do
+        let(:vrt_id) { 'insecure_data_storage.insecure_data_storage.password' }
+        let(:new_version) { '999.999' }
+
+        it 'should return top level category' do
+          expect(found_node.qualified_vrt_id).to eq 'insecure_data_storage'
+        end
+      end
+
       context 'and has no valid parent node' do
         let(:vrt_id) { 'sensitive_data_exposure.token_leakage_via_referer.over_https' }
         let(:new_version) { '2.0' }