Skip to content

Commit 3c3cd00

Browse files
TimmyBugcrowdjhas3c
TimmyBugcrowd
and
jhas3c
authored
Fixing-errors (#396)
* fixing-errors fixing-errors * Update vulnerability-rating-taxonomy.json * fixing-errors * broken_cryptography fix * broken_cryptography fix for cvss, cwe and remediation * Fixing-errors * Update deprecated-node-mapping.json * fixing-errors * Update deprecated-node-mapping.json * scw updated --------- Co-authored-by: Deepak Kumar Jha <[email protected]>
1 parent 439da3a commit 3c3cd00

File tree

7 files changed

+153
-141
lines changed

7 files changed

+153
-141
lines changed

‎CHANGELOG.md

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
1313
## [v1.11](https://github.com/bugcrowd/vulnerability-rating-taxonomy/compare/v1.10...v1.11) - 2023-11-20
1414
### Added
1515
- Sensitive Data Exposure - Disclosure of Secrets - PII Leakage/Exposure: VARIES
16-
- Sensitive Data Exposure - Disclosure of Secrets - Sensitive data Leakage/Exposure: P1
1716
- Server-Side Injection - Content Spoofing - HTML Content Injection: P5
1817
- Broken Authentication and Session Management - Failure to invalidate session - Permission change: VARIES
1918
- Server Security Misconfiguration - Request Smuggling: VARIES
19+
- Server-Side Injection - LDAP Injection: VARIES
2020
- Cryptographic Weakness - Insufficient Entropy - Limited Random Number Generator (RNG) Entropy Source: P4
2121
- Cryptographic Weakness - Insufficient_Entropy - Use of True Random Number Generator (TRNG) for Non-Security Purpose: P5
2222
- Cryptographic Weakness - Insufficient_Entropy - Pseudo-Random Number Generator (PRNG) Seed Reuse: P5
@@ -48,33 +48,40 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
4848
- Cryptographic Weakness - Incomplete Cleanup of Keying Material: P5
4949
- Cryptographic Weakness - Broken Cryptography - Use of Broken Cryptographic Primitive: P3
5050
- Cryptographic Weakness - Broken Cryptography - Use of Vulnerable Cryptographic Library: P4
51-
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Manipulate Non-Sensitive Information: P5
52-
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Manipulate Sensitive Information | GUID/Complex Object Identifiers: P4
53-
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Read Sensitive Information | Iteratable Object Identifiers: P3
54-
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Alter Sensitive Information | Iteratable Object Identifiers: P2
55-
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Read Sensitive Information (PII) | Iteratable Object Identifiers: P1
51+
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Read/Edit/Delete Non-Sensitive Information: P5
52+
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Read/Edit/Delete Sensitive Information/GUID/Complex Object Identifiers: P4
53+
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Read Sensitive Information/Iterable Object Identifiers: P3
54+
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Edit/Delete Sensitive Information/Iterable Object Identifiers: P2
55+
- Broken Access Control (BAC) - Insecure Direct Object References (IDOR) - Read/Edit/Delete Sensitive Information (PII)/Iterable Object Identifier: P1
5656

5757
### Changed
5858
FROM:
5959
- Cross-Site Scripting (XSS) - IE-Only - Older Version (< IE11): P5
60+
6061
TO:
6162
- Cross-Site Scripting (XSS) - IE-Only: P5
6263

63-
- FROM:
64+
FROM:
6465
- Broken Access Control (BAC) - Server-Side Request Forgery (SSRF) - Internal High Impact: P2
6566
- Broken Access Control (BAC) - Server-Side Request Forgery (SSRF) - Internal Scan and/or Medium Impact: P3
6667
- Broken Access Control (BAC) - Server-Side Request Forgery (SSRF) - External: P4
6768
- Broken Access Control (BAC) - Server-Side Request Forgery (SSRF) - DNS Query Only : P5
69+
6870
TO:
6971
- Server Security Misconfiguration - Server-Side Request Forgery (SSRF) - Internal High Impact: P2
7072
- Server Security Misconfiguration - Server-Side Request Forgery (SSRF) - Internal Scan and/or Medium Impact: P3
7173
- Server Security Misconfiguration - Server-Side Request Forgery (SSRF) - External - Low impact: P5
7274
- Server Security Misconfiguration - Server-Side Request Forgery (SSRF) - External - DNS Query Only: P5
7375

76+
FROM:
77+
- Automotive Security Misconfiguration - Infotainment, Radio Head Unit - PII Leakage: P1
78+
79+
TO:
80+
- Automotive Security Misconfiguration - Infotainment, Radio Head Unit - Sensitive data Leakage/Exposure: P1
7481
### Removed
7582
- Cross-Site Scripting (XSS) - IE-Only - IE11: P4
83+
- Cross-Site Scripting (XSS) - XSS Filter Disabled: P5
7684
- Broken Cryptography - Cryptographic Flaw - Incorrect Usage: P1
77-
- Automotive Security Misconfiguration - Infotainment, Radio Head Unit - PII Leakage: P1
7885

7986
## [v1.10.1](https://github.com/bugcrowd/vulnerability-rating-taxonomy/compare/v1.10...v1.10.1) - 2021-03-29
8087
### Changed

‎deprecated-node-mapping.json

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,5 +196,41 @@
196196
},
197197
"automotive_security_misconfiguration.infotainment.default_credentials": {
198198
"1.10": "automotive_security_misconfiguration.infotainment_radio_head_unit.default_credentials"
199+
},
200+
"broken_cryptography": {
201+
"1.11": "other"
202+
},
203+
"broken_cryptography.cryptographic_flaw": {
204+
"1.11": "other"
205+
},
206+
"broken_cryptography.cryptographic_flaw.incorrect_usage": {
207+
"1.11": "other"
208+
},
209+
"broken_cryptography.use_of_broken_cryptographic_primitive": {
210+
"1.11": "cryptographic_weakness.broken_cryptography.use_of_broken_cryptographic_primitive"
211+
},
212+
"broken_cryptography.use_of_vulnerable_cryptographic_library": {
213+
"1.11": "cryptographic_weakness.broken_cryptography.use_of_vulnerable_cryptographic_library"
214+
},
215+
"cross_site_scripting_xss.ie_only.older_version_ie11": {
216+
"1.11": "other"
217+
},
218+
"cross_site_scripting_xss.ie_only.xss_filter_disabled": {
219+
"1.11": "other"
220+
},
221+
"automotive_security_misconfiguration.infotainment_radio_head_unit.pii_leakage": {
222+
"1.11": "automotive_security_misconfiguration.infotainment_radio_head_unit.sensitive_data_leakage_exposure"
223+
},
224+
"broken_access_control.server_side_request_forgery_ssrf.internal_high_impact": {
225+
"1.11": "server_security_misconfiguration.server_side_request_forgery_ssrf.internal_high_impact"
226+
},
227+
"broken_access_control.server_side_request_forgery_ssrf.internal_scan_and_or_medium_impact": {
228+
"1.11": "server_security_misconfiguration.server_side_request_forgery_ssrf.internal_scan_and_or_medium_impact"
229+
},
230+
"broken_access_control.server_side_request_forgery_ssrf.dns_query_only": {
231+
"1.11": "server_security_misconfiguration.server_side_request_forgery_ssrf.external_dns_query_only"
232+
},
233+
"broken_access_control.server_side_request_forgery_ssrf.external": {
234+
"1.11": "server_security_misconfiguration.server_side_request_forgery_ssrf.external_low_impact"
199235
}
200236
}

‎mappings/cvss_v3/cvss_v3.json

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -966,6 +966,19 @@
966966
}
967967
]
968968
},
969+
{
970+
"id": "broken_cryptography",
971+
"children": [
972+
{
973+
"id": "use_of_broken_cryptographic_primitive",
974+
"cvss_v3": "AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:N"
975+
},
976+
{
977+
"id": "use_of_vulnerable_cryptographic_library",
978+
"cvss_v3": "AV:N/AC:H/PR:N/UI:R/S:U/C:H/I:H/A:N"
979+
}
980+
]
981+
},
969982
{
970983
"id": "side_channel_attack",
971984
"children": [
@@ -1001,19 +1014,6 @@
10011014
}
10021015
]
10031016
},
1004-
{
1005-
"id": "broken_cryptography",
1006-
"children": [
1007-
{
1008-
"id": "use_of_broken_cryptographic_primitive",
1009-
"cvss_v3": "AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:N"
1010-
},
1011-
{
1012-
"id": "use_of_vulnerable_cryptographic_library",
1013-
"cvss_v3": "AV:N/AC:H/PR:N/UI:R/S:U/C:H/I:H/A:N"
1014-
}
1015-
]
1016-
},
10171017
{
10181018
"id": "privacy_concerns",
10191019
"children": [

‎mappings/cwe/cwe.json

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -552,6 +552,20 @@
552552
}
553553
]
554554
},
555+
{
556+
"id": "broken_cryptography",
557+
"cwe": ["CWE-327"],
558+
"children": [
559+
{
560+
"id": "use_of_broken_cryptographic_primitive",
561+
"cwe": ["CWE-327"]
562+
},
563+
{
564+
"id": "use_of_vulnerable_cryptographic_library",
565+
"cwe": ["CWE-327"]
566+
}
567+
]
568+
},
555569
{
556570
"id": "side_channel_attack",
557571
"cwe": ["CWE-203", "CWE-1300"],
@@ -588,20 +602,6 @@
588602
}
589603
]
590604
},
591-
{
592-
"id": "broken_cryptography",
593-
"cwe": ["CWE-327"],
594-
"children": [
595-
{
596-
"id": "use_of_broken_cryptographic_primitive",
597-
"cwe": ["CWE-327"]
598-
},
599-
{
600-
"id": "use_of_vulnerable_cryptographic_library",
601-
"cwe": ["CWE-327"]
602-
}
603-
]
604-
},
605605
{
606606
"id": "privacy_concerns",
607607
"cwe": ["CWE-359"]

‎mappings/remediation_advice/remediation_advice.json

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,6 +1382,28 @@
13821382
}
13831383
]
13841384
},
1385+
{
1386+
"id": "broken_cryptography",
1387+
"children": [
1388+
{
1389+
"id": "use_of_broken_cryptographic_primitive",
1390+
"remediation_advice": "The use of broken, weak, or flawed cryptographic algorithms can allow an attacker to decrypt sensistive information. Ensure the application makes use of only trustworthy cryprographic algorithms as indicated by relevant security standard(s) and regulation(s).",
1391+
"references": [
1392+
"https://codeql.github.com/codeql-query-help/java/java-weak-cryptographic-algorithm/",
1393+
"https://csrc.nist.gov/csrc/media/publications/fips/140/2/final/documents/fips1402annexa.pdf",
1394+
"https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-131Ar2.pdf"
1395+
]
1396+
},
1397+
{
1398+
"id": "use_of_vulnerable_cryptographic_library",
1399+
"remediation_advice": "The identification, patching, and disclosure of vulnerabilities in third-party libraries, including cryptographic libraries, is a daily occurrence. In some cases, cryptographic libraries are deemed 'broken' and deprecated. Ensure the application is updated to include the latest secure version of all third-party cryptographic libraries and replace known 'broken' cryptographic libraries with secure alternatives.",
1400+
"references": [
1401+
"https://www.ubiqsecurity.com/bouncy-castle-and-the-impact-of-cryptographic-vulnerabilities/",
1402+
"https://blog.cryptographyengineering.com/2013/09/20/rsa-warns-developers-against-its-own/"
1403+
]
1404+
}
1405+
]
1406+
},
13851407
{
13861408
"id": "side_channel_attack",
13871409
"children": [
@@ -1449,28 +1471,6 @@
14491471
}
14501472
]
14511473
},
1452-
{
1453-
"id": "broken_cryptography",
1454-
"children": [
1455-
{
1456-
"id": "use_of_broken_cryptographic_primitive",
1457-
"remediation_advice": "The use of broken, weak, or flawed cryptographic algorithms can allow an attacker to decrypt sensistive information. Ensure the application makes use of only trustworthy cryprographic algorithms as indicated by relevant security standard(s) and regulation(s).",
1458-
"references": [
1459-
"https://codeql.github.com/codeql-query-help/java/java-weak-cryptographic-algorithm/",
1460-
"https://csrc.nist.gov/csrc/media/publications/fips/140/2/final/documents/fips1402annexa.pdf",
1461-
"https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-131Ar2.pdf"
1462-
]
1463-
},
1464-
{
1465-
"id": "use_of_vulnerable_cryptographic_library",
1466-
"remediation_advice": "The identification, patching, and disclosure of vulnerabilities in third-party libraries, including cryptographic libraries, is a daily occurrence. In some cases, cryptographic libraries are deemed 'broken' and deprecated. Ensure the application is updated to include the latest secure version of all third-party cryptographic libraries and replace known 'broken' cryptographic libraries with secure alternatives.",
1467-
"references": [
1468-
"https://www.ubiqsecurity.com/bouncy-castle-and-the-impact-of-cryptographic-vulnerabilities/",
1469-
"https://blog.cryptographyengineering.com/2013/09/20/rsa-warns-developers-against-its-own/"
1470-
]
1471-
}
1472-
]
1473-
},
14741474
{
14751475
"id": "privacy_concerns",
14761476
"remediation_advice": "1. Avoid storing unnecessary data where possible.\n2. Purge all known unnecessary data when identified on the device or application.\n3. Purge all known unnecessary data in known cached locations.\n4. Purge all known unnecessary data on known backup locations.",

‎third-party-mappings/remediation_training/secure-code-warrior-links.json

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -199,13 +199,10 @@
199199
"broken_access_control": null,
200200
"broken_access_control.idor": "https://integration-api.securecodewarrior.com/api/v1/trial?id=bugcrowd&mappingList=vrt&mappingKey=broken_access_control:idor&redirect=true",
201201
"broken_access_control.idor.read_edit_delete_non_sensitive_information": null,
202-
"broken_access_control.idor.read_edit_delete_sensitive_information": null,
203-
"broken_access_control.idor.read_edit_delete_sensitive_information.complext_object_identifiers": null,
204-
"broken_access_control.idor.read_sensitive_information": null,
205-
"broken_access_control.idor.read_sensitive_information.iterable_object_identifiers": null,
206-
"broken_access_control.idor.edit_delete_sensitive_information": null,
207-
"broken_access_control.idor.edit_delete_sensitive_information.iterable_object_identifiers": null,
208-
"broken_access_control.idor.edit_delete_sensitive_information.read_edit_delete_sensitive_information_pii": null,
202+
"broken_access_control.idor.read_edit_delete_sensitive_information_guid": null,
203+
"broken_access_control.idor.read_sensitive_information_iterable_object_identifiers": null,
204+
"broken_access_control.idor.edit_delete_sensitive_information_iterable_object_identifiers": null,
205+
"broken_access_control.idor.read_edit_delete_sensitive_information_iterable_object_identifiers": null,
209206
"broken_access_control.username_enumeration": null,
210207
"broken_access_control.username_enumeration.non_brute_force": "https://integration-api.securecodewarrior.com/api/v1/trial?id=bugcrowd&mappingList=vrt&mappingKey=broken_access_control:username_enumeration:non_brute_force&redirect=true",
211208
"broken_access_control.exposed_sensitive_android_intent": "https://integration-api.securecodewarrior.com/api/v1/trial?id=bugcrowd&mappingList=vrt&mappingKey=broken_access_control:exposed_sensitive_android_intent&redirect=true",
@@ -323,6 +320,9 @@
323320
"cryptographic_weakness.key_reuse.lack_of_perfect_forward_secrecy": null,
324321
"cryptographic_weakness.key_reuse.intra_environment": null,
325322
"cryptographic_weakness.key_reuse.inter_environment": null,
323+
"cryptographic_weakness.broken_cryptography": null,
324+
"cryptographic_weakness.broken_cryptography.use_of_broken_cryptographic_primitive": null,
325+
"cryptographic_weakness.broken_cryptography.use_of_vulnerable_cryptographic_library": null,
326326
"cryptographic_weakness.side_channel_attack": null,
327327
"cryptographic_weakness.side_channel_attack.padding_oracle_attack": null,
328328
"cryptographic_weakness.side_channel_attack.timing_attack": null,
@@ -331,9 +331,6 @@
331331
"cryptographic_weakness.side_channel_attack.differential_fault_analysis": null,
332332
"cryptographic_weakness.use_of_expired_cryptographic_key_or_cert": null,
333333
"cryptographic_weakness.incomplete_cleanup_of_keying_material": null,
334-
"broken_cryptography": null,
335-
"broken_cryptography.use_of_broken_cryptographic_primitive": null,
336-
"broken_cryptography.use_of_vulnerable_cryptographic_library": null,
337334
"privacy_concerns": null,
338335
"privacy_concerns.unnecessary_data_collection": null,
339336
"privacy_concerns.unnecessary_data_collection.wifi_ssid_password": "https://integration-api.securecodewarrior.com/api/v1/trial?id=bugcrowd&mappingList=vrt&mappingKey=privacy_concerns:unnecessary_data_collection:wifi_ssid_password&redirect=true",

0 commit comments

Comments
 (0)