Skip to content

Commit 2742c1c

Browse files
committed
Fixes problem with bool values
issue #11
1 parent a24feaf commit 2742c1c

File tree

4 files changed

+45
-10
lines changed

4 files changed

+45
-10
lines changed

components/ValueDump/ValueDump.vue

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<template>
22
<div class="dump-preview">
3-
<div v-if="!isString" class="var-dump-preview__html" v-html="dumpBody" />
3+
<div v-if="!isString" class="var-dump-preview__html" v-html="dumpBody"/>
44

5-
<CodeSnippet v-if="isString" language="php" :code="dumpBody" />
5+
<CodeSnippet v-if="isString" language="php" :code="dumpBody"/>
66
</div>
77
</template>
88

99
<script lang="ts">
10-
import { defineComponent } from "vue";
11-
import { useNuxtApp } from "#app";
10+
import {defineComponent} from "vue";
11+
import {useNuxtApp} from "#app";
1212
import CodeSnippet from "~/components/CodeSnippet/CodeSnippet.vue";
1313
1414
export default defineComponent({
@@ -18,7 +18,7 @@ export default defineComponent({
1818
props: ["value", "type"],
1919
setup() {
2020
if (process.client) {
21-
const { $vendors } = useNuxtApp();
21+
const {$vendors} = useNuxtApp();
2222
2323
return {
2424
Sfdump: $vendors.sfdump,
@@ -41,6 +41,10 @@ export default defineComponent({
4141
return this.value.toString().match(/(sf-dump-[0-9]+)/i)?.[0] || null;
4242
},
4343
dumpBody(): string | unknown {
44+
if (this.type === 'boolean') {
45+
return this.value === '1' ? 'true' : 'false';
46+
}
47+
4448
if (this.dumpId) {
4549
return (this.value as string).replace(
4650
/<(style|script)\b[^<]*(?:(?!<\/style>)<[^<]*)*<\/(style|script)>/gi,

components/VarDumpPreview/VarDumpPreview.stories.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import varDumpNumberEventMock from '~/mocks/var-dump-number.json'
66
import varDumpStringEventMock from '~/mocks/var-dump-string.json'
77
import varDumpStringEmptyEventMock from '~/mocks/var-dump-string-empty.json'
88
import varDumpArrayEventMock from '~/mocks/var-dump-array.json'
9-
import varDumpBoolEventMock from '~/mocks/var-dump-boolean.json'
9+
import varDumpBoolTrueEventMock from '~/mocks/var-dump-boolean-true.json'
10+
import varDumpBoolFalseEventMock from '~/mocks/var-dump-boolean-false.json'
1011
import VarDumpPreview from '~/components/VarDumpPreview/VarDumpPreview.vue';
1112

1213
export default {
@@ -48,10 +49,15 @@ StringEmpty.args = {
4849
event: normalizeVarDumpEvent(varDumpStringEmptyEventMock),
4950
};
5051

51-
export const Boolean = Template.bind({});
52+
export const BooleanTrue = Template.bind({});
5253

53-
Boolean.args = {
54-
event: normalizeVarDumpEvent(varDumpBoolEventMock),
54+
BooleanTrue.args = {
55+
event: normalizeVarDumpEvent(varDumpBoolTrueEventMock),
56+
};
57+
58+
export const BooleanFalse = Template.bind({});
59+
BooleanFalse.args = {
60+
event: normalizeVarDumpEvent(varDumpBoolFalseEventMock),
5561
};
5662

5763

mocks/var-dump-boolean.json renamed to mocks/var-dump-boolean-false.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"payload": {
55
"payload": {
66
"type": "boolean",
7-
"value": true
7+
"value": ""
88
},
99
"context": {
1010
"timestamp": 1678271981.325951,

mocks/var-dump-boolean-true.json

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
{
2+
"uuid": "49c77954-d17e-471d-9d5e-bf0aa856f90c",
3+
"type": "var-dump",
4+
"payload": {
5+
"payload": {
6+
"type": "boolean",
7+
"value": "1"
8+
},
9+
"context": {
10+
"timestamp": 1678271981.325951,
11+
"cli": {
12+
"command_line": "app.php",
13+
"identifier": "799f2007"
14+
},
15+
"source": {
16+
"name": "HomeController.php",
17+
"file": "/root/repos/spiral-apps/filters-bridge/app/src/Controller/HomeController.php",
18+
"line": 48,
19+
"file_excerpt": false
20+
}
21+
}
22+
},
23+
"timestamp": 1678271981,
24+
"project_id": null
25+
}

0 commit comments

Comments
 (0)