Skip to content

Commit ced9254

Browse files
committed
[#17] fix type errors for preview card
1 parent 5085f8e commit ced9254

File tree

3 files changed

+13436
-12860
lines changed

3 files changed

+13436
-12860
lines changed

components/PreviewCard/PreviewCard.vue

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@
1111
:event-type="event.type"
1212
:event-id="event.id"
1313
:tags="normalizedTags"
14-
:is-open="!isCollapsed && !isOptimised"
15-
:is-visible-controls="isVisibleControls"
14+
:is-open="!isCollapsed && !isOptimized"
15+
:is-visible-controls="isVisibleControls && !isOptimized"
1616
@toggle-view="toggle"
1717
@delete="deleteEvent"
1818
@copy="copyCode"
1919
@download="downloadImage"
2020
/>
2121

2222
<div
23-
v-if="!isCollapsed && !isOptimised"
23+
v-if="!isCollapsed && !isOptimized"
2424
ref="event_body"
2525
class="preview-card__body"
2626
>
@@ -29,7 +29,7 @@
2929

3030
<PreviewCardFooter
3131
v-if="
32-
!isCollapsed && !isOptimised && (normalizedOrigin || event.serverName)
32+
!isCollapsed && !isOptimized && (normalizedOrigin || event.serverName)
3333
"
3434
class="preview-card__footer"
3535
:server-name="event.serverName"
@@ -77,7 +77,7 @@ export default defineComponent({
7777
data() {
7878
return {
7979
isCollapsed: false,
80-
isOptimised: false,
80+
isOptimized: false,
8181
isVisibleControls: true,
8282
};
8383
},
@@ -147,20 +147,23 @@ export default defineComponent({
147147
},
148148
optimiseRenderHidden() {
149149
return debounce(() => {
150-
const { top, height } = this.$refs.event.getBoundingClientRect();
151-
const extraDelta = height;
152-
const isVisible =
153-
top - extraDelta <= window.innerHeight &&
154-
top + height + extraDelta * 2 >= 0;
150+
if (this.$refs.event) {
151+
const eventNode = this.$refs.event as HTMLElement;
152+
const { top, height } = eventNode.getBoundingClientRect();
153+
const extraDelta = height;
154+
const isVisible =
155+
top - extraDelta <= window.innerHeight &&
156+
top + height + extraDelta * 2 >= 0;
155157
156-
if (!isVisible && !this.isOptimised) {
157-
this.isOptimised = true;
158-
this.$refs.event.style.height = `${this.$refs.event.clientHeight}px`;
159-
} else if (isVisible && this.isOptimised) {
160-
this.isOptimised = false;
161-
this.$refs.event.style.height = "auto";
158+
if (!isVisible && !this.isOptimized) {
159+
this.isOptimized = true;
160+
eventNode.style.height = `${eventNode.clientHeight}px`;
161+
} else if (isVisible && this.isOptimized) {
162+
this.isOptimized = false;
163+
eventNode.style.height = "auto";
164+
}
162165
}
163-
}, 50);
166+
}, 30);
164167
},
165168
},
166169
});

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
"@storybook/addon-postcss": "^2.0.0",
3636
"@storybook/builder-vite": "^0.3.0",
3737
"@types/downloadjs": "^1.4.3",
38+
"@types/lodash.debounce": "^4.0.7",
3839
"@typescript-eslint/eslint-plugin": "^5.48.2",
3940
"@typescript-eslint/parser": "^5.48.2",
4041
"@vitejs/plugin-vue": "^4.0.0",

0 commit comments

Comments
 (0)