fix(MailToFileSender): allow _ in email names (#155)

gam6itko · web-flow · commit 4e207ba50485 · 2025-01-19T23:14:48.000+04:00
diff --git a/src/Sender/MailToFileSender.php b/src/Sender/MailToFileSender.php
@@ -52,7 +52,7 @@ public function send(iterable $frames): void
     private static function normalizeEmail(?string $email): ?string
     {
         $normalized = \preg_replace(
-            ['/[^a-z0-9.\\- @]/i', '/\s+/'],
+            ['/[^a-z0-9.\\-_ @]/i', '/\s+/'],
             ['!', '_'],
             (string) $email,
         );
diff --git a/tests/Unit/Sender/MailToFileSenderTest.php b/tests/Unit/Sender/MailToFileSenderTest.php
@@ -36,7 +36,7 @@ public function testForSmtp(): void
                     'User1 <user1@company.tld>',
                     'user2@company.tld',
                     'User without email', // no email
-                    'User3 <user3@inline.com>, User4 <user4@inline.com>, user5@inline.com',
+                    'User3 <user3@inline.com>, User4 <user4@inline.com>, us_er_5@inline.com',
                 ],
                 'Subject' => ['Very important theme'],
                 'Content-Type' => ['text/plain'],
@@ -50,7 +50,7 @@ public function testForSmtp(): void
         $this->assertRecipient("$root/user2@company.tld");
         $this->assertRecipient("$root/user3@inline.com");
         $this->assertRecipient("$root/user4@inline.com");
-        $this->assertRecipient("$root/user5@inline.com");
+        $this->assertRecipient("$root/us_er_5@inline.com");
     }
 
     protected function tearDown(): void

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function send(iterable $frames): void`
`52`	`52`	`private static function normalizeEmail(?string $email): ?string`
`53`	`53`	`{`
`54`	`54`	`$normalized = \preg_replace(`
`55`		`- ['/[^a-z0-9.\\- @]/i', '/\s+/'],`
	`55`	`+ ['/[^a-z0-9.\\-_ @]/i', '/\s+/'],`
`56`	`56`	`['!', '_'],`
`57`	`57`	`(string) $email,`
`58`	`58`	`);`
-Original file line number
+Diff line change
                     'User1 <[email protected]>',
                     '[email protected]',
                     'User without email', // no email
 -                    'User3 <[email protected]>, User4 <[email protected]>, user5@inline.com',
 +                    'User3 <[email protected]>, User4 <[email protected]>, us_er_5@inline.com',
                 ],
                 'Subject' => ['Very important theme'],
                 'Content-Type' => ['text/plain'],
         $this->assertRecipient("$root/[email protected]");
         $this->assertRecipient("$root/[email protected]");
         $this->assertRecipient("$root/[email protected]");
 -        $this->assertRecipient("$root/user5@inline.com");
 +        $this->assertRecipient("$root/us_er_5@inline.com");
+    }
     protected function tearDown(): void