Skip to content

Commit 99977a2

Browse files
authored
Merge pull request #210: Fix Symfony 8 compatibility
2 parents a4f46cc + 4e649bc commit 99977a2

File tree

4 files changed

+255
-164
lines changed

4 files changed

+255
-164
lines changed

.github/workflows/testing.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,12 @@ jobs:
2727
- 8.2
2828
- 8.3
2929
- 8.4
30-
- 8.5
3130
dependencies:
3231
- lowest
3332
- locked
3433
- highest
3534
include:
36-
- php-version: 8.4
35+
- php-version: 8.5
3736
dependencies: highest
3837
steps:
3938
- name: 📦 Check out the codebase
@@ -51,6 +50,7 @@ jobs:
5150
- name: 📥 Install dependencies with composer
5251
uses: ramsey/composer-install@v3
5352
with:
53+
composer-options: ${{ matrix.php-version == '8.5' && '--ignore-platform-reqs' || '' }}
5454
dependency-versions: ${{ matrix.dependencies }}
5555

5656
- name: 🧪 Run tests

bin/trap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ use Symfony\Component\Console\CommandLoader\FactoryCommandLoader;
4545
$application = new Application();
4646
$application->setCommandLoader(
4747
new FactoryCommandLoader([
48-
Command\Run::getDefaultName() => static fn() => new Command\Run(),
49-
Command\Joke::getDefaultName() => static fn() => new Command\Joke(),
50-
Command\Test::getDefaultName() => static fn() => new Command\Test(),
48+
'run' => static fn(): Command\Run => new Command\Run(),
49+
'joke' => static fn(): Command\Joke => new Command\Joke(),
50+
'test' => static fn(): Command\Test => new Command\Test(),
5151
]),
5252
);
53-
$application->setDefaultCommand(Command\Run::getDefaultName(), false);
53+
$application->setDefaultCommand('run', false);
5454
$application->setName(Info::NAME);
5555
$application->setVersion(Info::version());
5656
$application->run();

composer.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
],
3838
"require": {
3939
"php": ">=8.1",
40+
"php-64bit": "*",
4041
"ext-filter": "*",
4142
"ext-sockets": "*",
4243
"clue/stream-filter": "^1.6",
@@ -90,9 +91,6 @@
9091
"audit": {
9192
"abandoned": "report"
9293
},
93-
"platform": {
94-
"php": "8.1.27"
95-
},
9694
"sort-packages": true
9795
},
9896
"scripts": {

0 commit comments

Comments
 (0)