Skip to content

Fix Symfony 8 compatibility #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxblnfk merged 3 commits into from
Dec 27, 2025
Merged

Fix Symfony 8 compatibility #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddd5c5b
fix: Stop using removed `Command::getDefaultName()`
roxblnfk Dec 27, 2025
ead0c36
fix(Composer): Add PHP 64bit requirement;
roxblnfk Dec 27, 2025
4e649bc
ci(Tests): Ignore platform reqs for PHP 8.5
roxblnfk Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,12 @@ jobs:
- 8.2
- 8.3
- 8.4
- 8.5
dependencies:
- lowest
- locked
- highest
include:
- php-version: 8.4
- php-version: 8.5
dependencies: highest
steps:
- name: 📦 Check out the codebase
Expand All @@ -51,6 +50,7 @@ jobs:
- name: 📥 Install dependencies with composer
uses: ramsey/composer-install@v3
with:
composer-options: ${{ matrix.php-version == '8.5' && '--ignore-platform-reqs' || '' }}
dependency-versions: ${{ matrix.dependencies }}

- name: 🧪 Run tests
Expand Down
8 changes: 4 additions & 4 deletions bin/trap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ use Symfony\Component\Console\CommandLoader\FactoryCommandLoader;
$application = new Application();
$application->setCommandLoader(
new FactoryCommandLoader([
Command\Run::getDefaultName() => static fn() => new Command\Run(),
Command\Joke::getDefaultName() => static fn() => new Command\Joke(),
Command\Test::getDefaultName() => static fn() => new Command\Test(),
'run' => static fn(): Command\Run => new Command\Run(),
'joke' => static fn(): Command\Joke => new Command\Joke(),
'test' => static fn(): Command\Test => new Command\Test(),
]),
);
$application->setDefaultCommand(Command\Run::getDefaultName(), false);
$application->setDefaultCommand('run', false);
$application->setName(Info::NAME);
$application->setVersion(Info::version());
$application->run();
Expand Down
4 changes: 1 addition & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
],
"require": {
"php": ">=8.1",
"php-64bit": "*",
"ext-filter": "*",
"ext-sockets": "*",
"clue/stream-filter": "^1.6",
Expand Down Expand Up @@ -90,9 +91,6 @@
"audit": {
"abandoned": "report"
},
"platform": {
"php": "8.1.27"
},
"sort-packages": true
},
"scripts": {
Expand Down
Loading
Loading