Merge pull request #243 from bugsnag/release/v3.5.0

joshedney · web-flow · commit c5dcfa3c3bdb · 2025-11-12T12:55:21.000Z
v3.5.0 Release
diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
@@ -111,7 +111,7 @@ steps:
       - label: ":video_game: Unity Android Integration Tests"
         depends_on: build
         env:
-          UNITY_VERSION: 6000.2.2f1
+          UNITY_VERSION: 6000.2.10f1
         agents:
           queue: macos-15-isolated
         commands:
@@ -128,7 +128,7 @@ steps:
       - label: ":video_game: Unity iOS Integration Tests"
         depends_on: build
         env:
-          UNITY_VERSION: 6000.2.2f1
+          UNITY_VERSION: 6000.2.10f1
         agents:
           queue: macos-15-isolated
         commands:
@@ -174,3 +174,12 @@ steps:
         timeout_in_minutes: 5
         commands:
           - buildkite-agent pipeline upload .buildkite/react-native/ios.pipeline.yml
+
+      - label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: REACT NATIVE STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
+        depends_on:
+          - "build"
+        agents:
+          queue: "macos"
+        timeout_in_minutes: 5
+        commands:
+          - buildkite-agent pipeline upload .buildkite/react-native/react-native.pipeline.yml
diff --git a/.buildkite/react-native/react-native.pipeline.yml b/.buildkite/react-native/react-native.pipeline.yml
@@ -0,0 +1,22 @@
+agents:
+  queue: macos-15
+
+steps:
+  - label: ':react: Integration Tests'
+    key: "react-native-cli"
+    timeout_in_minutes: 15
+    env:
+    commands:
+      - "chmod +x bin/arm64-macos-bugsnag-cli"
+      - "bundle install"
+      - "bundle exec maze-runner --port=$((MAZE_RUNNER_PORT)) --document-server-port=$((MAZE_RUNNER_PORT + 1)) features/react-native/react-native.feature"
+    plugins:
+      artifacts#v1.5.0:
+        download:
+          - bin/arm64-macos-bugsnag-cli
+        upload:
+          - maze_output/**/*
+    retry:
+      automatic:
+        - exit_status: "*"
+          limit: 1
diff --git a/.github/workflows/downstream_updates.yml b/.github/workflows/downstream_updates.yml
@@ -18,20 +18,23 @@ jobs:
       RELEASE_VERSION: ${{ github.event_name == 'workflow_dispatch' && inputs.target_version || github.event.release.tag_name }}
     strategy:
       matrix:
-        downstream_repo: ['bugsnag/bugsnag-unity']
+        downstream_repo: [
+          'bugsnag/bugsnag-unity',
+          'bugsnag/homebrew-tap'
+        ]
     steps:
       - name: Install libcurl4-openssl-dev and net-tools
         run: |
           sudo apt-get update
           sudo apt-get install libcurl4-openssl-dev net-tools
 
       - run: >
-          curl -X POST https://api.github.com/repos/bugsnag/bugsnag-unity/dispatches
+          curl -X POST https://api.github.com/repos/${{ matrix.downstream_repo }}/dispatches
           -H 'Content-Type: application/json'
           -H "Authorization: Bearer ${{ secrets.DEP_UPDATER_BEARER_TOKEN }}"
           -d '{
             "event_type": "update-cli",
             "client_payload": {
               "cli_version": "${{ env.RELEASE_VERSION }}"
             }
-          }'
+          }'
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,15 @@
 # Changelog
 
+## [3.5.0] - 2025-11-12
+
+### Added
+
+- Add support for uploading React Native Sourcemaps outside of Android or iOS builds [#241](https://github.com/bugsnag/bugsnag-cli/pull/241)
+
+### Changed
+
+- `bugsnag-cli-placeholder` now throws an `Error` instead of just logging to the console. This immediately stops execution and should return a stack trace if the CLI is not successfully installed [#239](https://github.com/bugsnag/bugsnag-cli/pull/239)
+
 ## [3.4.1] - 2025-09-30
 
 ### Fixed 
diff --git a/README.md b/README.md
@@ -36,7 +36,7 @@ The script downloads the appropriate binary and attempts to install it to `~/.lo
 If your project uses `npm` or `yarn`, the CLI can be installed by adding the [`@bugsnag/cli`](https://www.npmjs.com/package/@bugsnag/cli) package:
 
 ```sh
-npm install @bugsnag/cli`
+npm install @bugsnag/cli
 ```
 
 It can then be executed from your project scripts at `/node_modules/.bin/bugsnag-cli` or using `npx @bugsnag/cli`.
diff --git a/features/react-native/fixtures/vega/index.bundle b/features/react-native/fixtures/vega/index.bundle
@@ -0,0 +1 @@
+index.bundle
diff --git a/features/react-native/fixtures/vega/index.bundle.map b/features/react-native/fixtures/vega/index.bundle.map
@@ -0,0 +1 @@
+{'index.bundle.map':''}
diff --git a/features/react-native/react-native.feature b/features/react-native/react-native.feature
@@ -0,0 +1,25 @@
+Feature: React Native Integration Tests
+  Scenario: Upload a single React Native sourcemap
+    When I run bugsnag-cli with upload react-native-sourcemaps --upload-api-root-url=http://localhost:$MAZE_RUNNER_PORT --api-key=1234567890ABCDEF1234567890ABCDEF --version-name=1.0 --version-code=123.456 --source-map=features/react-native/fixtures/vega/index.bundle.map --bundle=features/react-native/fixtures/vega/index.bundle --platform=vega
+    And I wait to receive 1 sourcemaps
+    Then the sourcemaps are valid for the API
+    Then the sourcemaps Content-Type header is valid multipart form-data
+    Then the sourcemap payload fields should be:
+      | apiKey            | 1234567890ABCDEF1234567890ABCDEF  |
+      | appVersion        | 1.0                               |
+      | appVersionCode    | 123.456                           |
+      | platform          | vega                              |
+
+  Scenario: Upload a single React Native sourcemap providing both version-code and bundle-version
+    When I run bugsnag-cli with upload react-native-sourcemaps --upload-api-root-url=http://localhost:$MAZE_RUNNER_PORT --api-key=1234567890ABCDEF1234567890ABCDEF --version-name=1.0 --version-code=123.456  --bundle-version=123.456 --source-map=features/react-native/fixtures/vega/index.bundle.map --bundle=features/react-native/fixtures/vega/index.bundle --platform=vega
+    Then the error should contain "--version-code and --bundle-version can't be used together"
+
+  Scenario: Upload a single React Native sourcemap providing code-bundle-id
+    When I run bugsnag-cli with upload react-native-sourcemaps --upload-api-root-url=http://localhost:$MAZE_RUNNER_PORT --api-key=1234567890ABCDEF1234567890ABCDEF --code-bundle-id=123.456 --source-map=features/react-native/fixtures/vega/index.bundle.map --bundle=features/react-native/fixtures/vega/index.bundle --platform=vega
+    And I wait to receive 1 sourcemaps
+    Then the sourcemaps are valid for the API
+    Then the sourcemaps Content-Type header is valid multipart form-data
+    Then the sourcemap payload fields should be:
+      | apiKey            | 1234567890ABCDEF1234567890ABCDEF  |
+      | codeBundleId      | 123.456                           |
+      | platform          | vega                              |
diff --git a/features/steps/steps.rb b/features/steps/steps.rb
@@ -76,6 +76,10 @@
   Maze.check.include(run_output, "Path ambiguous: more than one AAB file was found")
 end
 
+Then('the error should contain {string}') do |error_message|
+  Maze.check.include(run_output, error_message)
+end
+
 Then('the sourcemap is valid for the dSYM Build API') do
   steps %(
     And the sourcemap payload field "apiKey" equals "#{$api_key}"
diff --git a/install.sh b/install.sh
@@ -91,7 +91,7 @@ display_help() {
 EOS
 }
 
-VERSION="3.4.1"
+VERSION="3.5.0"
 
 while [[ "$#" -gt 0 ]]; do
   case "$1" in
diff --git a/js/bin/bugsnag-cli-placeholder b/js/bin/bugsnag-cli-placeholder
@@ -1,3 +1,3 @@
 #!/usr/bin/env node
 
-console.log("error - bugsnag-cli binary has not been installed successfully")
+throw new Error("bugsnag-cli binary has not been installed successfully")
diff --git a/js/package.json b/js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bugsnag/cli",
-  "version": "3.4.1",
+  "version": "3.5.0",
   "description": "BugSnag CLI",
   "main": "dist/bugsnag-cli-wrapper.js",
   "types": "dist/bugsnag-cli-wrapper.d.ts",
diff --git a/main.go b/main.go
@@ -11,7 +11,7 @@ import (
 	"github.com/bugsnag/bugsnag-cli/pkg/upload"
 )
 
-var package_version = "3.4.1"
+var package_version = "3.5.0"
 
 func main() {
 	commands := options.CLI{}
@@ -98,6 +98,12 @@ func main() {
 			logger.Fatal(err.Error())
 		}
 
+	case "upload react-native-sourcemaps", "upload react-native-sourcemaps <path>":
+		err := upload.ProcessReactNativeSourcemaps(commands, logger)
+		if err != nil {
+			logger.Fatal(err.Error())
+		}
+
 	case "upload react-native-android", "upload react-native-android <path>":
 
 		err := upload.ProcessReactNativeAndroid(commands, logger)
diff --git a/pkg/options/options.go b/pkg/options/options.go
@@ -102,55 +102,6 @@ type Js struct {
 	Overwrite    bool        `help:"Whether to ignore and overwrite existing uploads with same identifier, rather than failing if a matching file exists"`
 }
 
-type ReactNative struct {
-	Path            utils.Paths                `arg:"" name:"path" help:"The path to the root of the React Native project to upload files from" type:"path" default:"."`
-	ProjectRoot     string                     `help:"The path to strip from the beginning of source file names referenced in stacktraces on the BugSnag dashboard" type:"path"`
-	Shared          ReactNativeShared          `embed:""`
-	AndroidSpecific ReactNativeAndroidSpecific `embed:"" prefix:"android-"`
-	IosSpecific     ReactNativeIosSpecific     `embed:"" prefix:"ios-"`
-	Overwrite       bool                       `help:"Whether to ignore and overwrite existing uploads with same identifier, rather than failing if a matching file exists"`
-}
-
-type ReactNativeAndroidSpecific struct {
-	AppManifest string `help:"The path to a manifest file (AndroidManifest.xml) from which to obtain build information" type:"path"`
-	Variant     string `help:"The build type/flavor (e.g. debug, release) used to disambiguate the between built files when searching the project directory"`
-	VersionCode string `help:"The version code of this build of the application"`
-}
-
-type ReactNativeAndroid struct {
-	Path        utils.Paths `arg:"" name:"path" help:"The path to the root of the React Native project to upload files from" type:"path" default:"."`
-	ProjectRoot string      `help:"The path to strip from the beginning of source file names referenced in stacktraces on the BugSnag dashboard" type:"path"`
-
-	ReactNative ReactNativeShared          `embed:""`
-	Android     ReactNativeAndroidSpecific `embed:""`
-	Overwrite   bool                       `help:"Whether to ignore and overwrite existing uploads with same identifier, rather than failing if a matching file exists"`
-}
-
-type ReactNativeShared struct {
-	Bundle       string `help:"The path to the bundled JavaScript file to upload" type:"path"`
-	CodeBundleId string `help:"A unique identifier for the JavaScript bundle"`
-	Dev          bool   `help:"Indicates whether this is a debug or release build"`
-	SourceMap    string `help:"The path to the source map file to upload" type:"path"`
-	VersionName  string `help:"The version of the application"`
-}
-
-type ReactNativeIosSpecific struct {
-	BundleVersion string     `help:"The bundle version of this build of the application (Apple platforms only)"`
-	Plist         string     `help:"The path to a .plist file from which to obtain build information" type:"path"`
-	Scheme        string     `help:"The name of the Xcode options.Ios.Scheme used to build the application"`
-	XcodeProject  string     `help:"The path to an Xcode project, workspace or containing directory from which to obtain build information" type:"path"`
-	XcarchivePath utils.Path `help:"The path to the Xcode archive to process if it has been exported" type:"path"`
-}
-
-type ReactNativeIos struct {
-	Path        utils.Paths `arg:"" name:"path" help:"The path to the root of the React Native project to upload files from" type:"path" default:"."`
-	ProjectRoot string      `help:"The path to strip from the beginning of source file names referenced in stacktraces on the BugSnag dashboard" type:"path"`
-
-	ReactNative ReactNativeShared      `embed:""`
-	Ios         ReactNativeIosSpecific `embed:""`
-	Overwrite   bool                   `help:"Whether to ignore and overwrite existing uploads with same identifier, rather than failing if a matching file exists"`
-}
-
 type Breakpad struct {
 	Path            utils.Paths `arg:"" name:"path" help:"The path to the symbol files (.sym) to upload (or directory containing them)" type:"path"`
 	CpuArch         string      `help:"The CPU architecture that the module was built for"`
@@ -171,22 +122,23 @@ type Upload struct {
 	UploadAPIRootUrl string `help:"The upload server hostname, optionally containing port number"`
 
 	// required options
-	All                DiscoverAndUploadAny   `cmd:"" help:"Upload any symbol/mapping files"`
-	AndroidAab         AndroidAabMapping      `cmd:"" help:"Process and upload application bundle files for Android"`
-	AndroidNdk         AndroidNdkMapping      `cmd:"" help:"Process and upload NDK symbol files for Android"`
-	AndroidProguard    AndroidProguardMapping `cmd:"" help:"Process and upload Proguard/R8 mapping files for Android"`
-	DartSymbol         DartSymbol             `cmd:"" help:"Process and upload symbol files for Flutter" name:"dart"`
-	XcodeBuild         XcodeBuild             `cmd:"" help:"Upload dSYMs for iOS from a build"`
-	Dsym               Dsym                   `cmd:"" help:"(deprecated) Upload dSYMs for iOS"`
-	XcodeArchive       XcodeArchive           `cmd:"" help:"Upload dSYMs for iOS from a Xcode archive"`
-	Js                 Js                     `cmd:"" help:"Upload source maps for JavaScript"`
-	ReactNative        ReactNative            `cmd:"" help:"Upload source maps for React Native"`
-	ReactNativeAndroid ReactNativeAndroid     `cmd:"" help:"Upload source maps for React Native Android"`
-	ReactNativeIos     ReactNativeIos         `cmd:"" help:"Upload source maps for React Native iOS"`
-	UnityAndroid       UnityAndroid           `cmd:"" help:"Upload Android mappings and NDK symbol files from Unity projects"`
-	UnityIos           UnityIos               `cmd:"" help:"Upload iOS mappings and dSYMs from Unity projects"`
-	Breakpad           Breakpad               `cmd:"" help:"Upload breakpad .sym files"`
-	Linux              LinuxOptions           `cmd:"" help:"Upload symbol/mapping files"`
+	All                   DiscoverAndUploadAny   `cmd:"" help:"Upload any symbol/mapping files"`
+	AndroidAab            AndroidAabMapping      `cmd:"" help:"Process and upload application bundle files for Android"`
+	AndroidNdk            AndroidNdkMapping      `cmd:"" help:"Process and upload NDK symbol files for Android"`
+	AndroidProguard       AndroidProguardMapping `cmd:"" help:"Process and upload Proguard/R8 mapping files for Android"`
+	DartSymbol            DartSymbol             `cmd:"" help:"Process and upload symbol files for Flutter" name:"dart"`
+	XcodeBuild            XcodeBuild             `cmd:"" help:"Upload dSYMs for iOS from a build"`
+	Dsym                  Dsym                   `cmd:"" help:"(deprecated) Upload dSYMs for iOS"`
+	XcodeArchive          XcodeArchive           `cmd:"" help:"Upload dSYMs for iOS from a Xcode archive"`
+	Js                    Js                     `cmd:"" help:"Upload source maps for JavaScript"`
+	ReactNative           ReactNative            `cmd:"" help:"Upload source maps for React Native"`
+	ReactNativeAndroid    ReactNativeAndroid     `cmd:"" help:"Upload source maps for React Native Android"`
+	ReactNativeIos        ReactNativeIos         `cmd:"" help:"Upload source maps for React Native iOS"`
+	ReactNativeSourcemaps ReactNativeSourcemaps  `cmd:"" help:"Upload source maps for React Native"`
+	UnityAndroid          UnityAndroid           `cmd:"" help:"Upload Android mappings and NDK symbol files from Unity projects"`
+	UnityIos              UnityIos               `cmd:"" help:"Upload iOS mappings and dSYMs from Unity projects"`
+	Breakpad              Breakpad               `cmd:"" help:"Upload breakpad .sym files"`
+	Linux                 LinuxOptions           `cmd:"" help:"Upload symbol/mapping files"`
 }
 
 // Unique CLI options
diff --git a/pkg/options/react-native.go b/pkg/options/react-native.go
@@ -0,0 +1,66 @@
+package options
+
+import "github.com/bugsnag/bugsnag-cli/pkg/utils"
+
+type ReactNative struct {
+	Path            utils.Paths                `arg:"" name:"path" help:"The path to the root of the React Native project to upload files from" type:"path" default:"."`
+	ProjectRoot     string                     `help:"The path to strip from the beginning of source file names referenced in stacktraces on the BugSnag dashboard" type:"path"`
+	Shared          ReactNativeShared          `embed:""`
+	AndroidSpecific ReactNativeAndroidSpecific `embed:"" prefix:"android-"`
+	IosSpecific     ReactNativeIosSpecific     `embed:"" prefix:"ios-"`
+	Overwrite       bool                       `help:"Whether to ignore and overwrite existing uploads with same identifier, rather than failing if a matching file exists"`
+}
+
+type ReactNativeAndroidSpecific struct {
+	AppManifest string `help:"The path to a manifest file (AndroidManifest.xml) from which to obtain build information" type:"path"`
+	Variant     string `help:"The build type/flavor (e.g. debug, release) used to disambiguate the between built files when searching the project directory"`
+	VersionCode string `help:"The version code of this build of the application"`
+}
+
+type ReactNativeAndroid struct {
+	Path        utils.Paths `arg:"" name:"path" help:"The path to the root of the React Native project to upload files from" type:"path" default:"."`
+	ProjectRoot string      `help:"The path to strip from the beginning of source file names referenced in stacktraces on the BugSnag dashboard" type:"path"`
+
+	ReactNative ReactNativeShared          `embed:""`
+	Android     ReactNativeAndroidSpecific `embed:""`
+	Overwrite   bool                       `help:"Whether to ignore and overwrite existing uploads with same identifier, rather than failing if a matching file exists"`
+}
+
+type ReactNativeShared struct {
+	Bundle       string `help:"The path to the bundled JavaScript file to upload" type:"path"`
+	CodeBundleId string `help:"A unique identifier for the JavaScript bundle"`
+	Dev          bool   `help:"Indicates whether this is a debug or release build"`
+	SourceMap    string `help:"The path to the source map file to upload" type:"path"`
+	VersionName  string `help:"The version of the application"`
+}
+
+type ReactNativeIosSpecific struct {
+	BundleVersion string     `help:"The bundle version of this build of the application (Apple platforms only)"`
+	Plist         string     `help:"The path to a .plist file from which to obtain build information" type:"path"`
+	Scheme        string     `help:"The name of the Xcode options.Ios.Scheme used to build the application"`
+	XcodeProject  string     `help:"The path to an Xcode project, workspace or containing directory from which to obtain build information" type:"path"`
+	XcarchivePath utils.Path `help:"The path to the Xcode archive to process if it has been exported" type:"path"`
+}
+
+type ReactNativeIos struct {
+	Path        utils.Paths `arg:"" name:"path" help:"The path to the root of the React Native project to upload files from" type:"path" default:"."`
+	ProjectRoot string      `help:"The path to strip from the beginning of source file names referenced in stacktraces on the BugSnag dashboard" type:"path"`
+
+	ReactNative ReactNativeShared      `embed:""`
+	Ios         ReactNativeIosSpecific `embed:""`
+	Overwrite   bool                   `help:"Whether to ignore and overwrite existing uploads with same identifier, rather than failing if a matching file exists"`
+}
+
+type ReactNativeSourcemaps struct {
+	Path          utils.Path     `arg:"" name:"path" help:"The path to the root of the React Native project to upload files from" type:"path" default:"."`
+	ProjectRoot   string         `help:"The path to strip from the beginning of source file names referenced in stacktraces on the BugSnag dashboard" type:"path"`
+	VersionName   string         `help:"The version of the application"`
+	VersionCode   string         `help:"The version code of this build of the application" xor:"version-code,bundle-version"`
+	BundleVersion string         `help:"The bundle version of this build of the application (Apple platforms only)" xor:"version-code,bundle-version"`
+	CodeBundleId  string         `help:"A unique identifier for the JavaScript bundle"`
+	Dev           bool           `help:"Indicates whether this is a debug or release build"`
+	Overwrite     bool           `help:"Whether to ignore and overwrite existing uploads with same identifier, rather than failing if a matching file exists"`
+	SourceMap     string         `help:"The path to the source map file to upload" type:"path"`
+	Bundle        string         `help:"The path to the bundled JavaScript file to upload" type:"path"`
+	Platform      utils.Platform `help:"The platform of the React Native build"`
+}
diff --git a/pkg/upload/react-native-android.go b/pkg/upload/react-native-android.go
diff --git a/pkg/upload/react-native-ios.go b/pkg/upload/react-native-ios.go
diff --git a/pkg/upload/react-native-sourcemaps.go b/pkg/upload/react-native-sourcemaps.go
diff --git a/pkg/utils/upload-options.go b/pkg/utils/upload-options.go
diff --git a/pkg/utils/validation.go b/pkg/utils/validation.go

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ display_help() {`
`91`	`91`	`EOS`
`92`	`92`	`}`
`93`	`93`
`94`		`-VERSION="3.4.1"`
	`94`	`+VERSION="3.5.0"`
`95`	`95`
`96`	`96`	`while [[ "$#" -gt 0 ]]; do`
`97`	`97`	`case "$1" in`