Skip to content

Commit a409e99

Browse files
joshedneyjoshedney
authored
Merge pull request #2653 from bugsnag/je/plat-15309-ios-updates
Ensure we're using the latest versions of iOS for testing
2 parents 0522d07 + c5bc09c commit a409e99

File tree

4 files changed

+17
-20
lines changed

4 files changed

+17
-20
lines changed

‎.buildkite/basic/react-native-ios-full-pipeline.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ steps:
153153
command:
154154
- --app=/app/features/fixtures/generated/old-arch/{{matrix}}/output/reactnative.ipa
155155
- --farm=bb
156-
- --device=IOS_15
156+
- --device=IOS_17|IOS_18|IOS_26
157157
- --fail-fast
158158
- --no-tunnel
159159
- --aws-public-ip
@@ -199,7 +199,7 @@ steps:
199199
command:
200200
- --app=/app/features/fixtures/generated/new-arch/{{matrix.reactnative}}/output/reactnative.ipa
201201
- --farm=bb
202-
- --device=IOS_15
202+
- --device=IOS_17|IOS_18|IOS_26
203203
- --fail-fast
204204
- --no-tunnel
205205
- --aws-public-ip
@@ -253,7 +253,7 @@ steps:
253253
command:
254254
- --app=/app/features/fixtures/generated/react-native-navigation/old-arch/{{matrix}}/output/reactnative.ipa
255255
- --farm=bb
256-
- --device=IOS_15
256+
- --device=IOS_17|IOS_18|IOS_26
257257
- --fail-fast
258258
- --no-tunnel
259259
- --aws-public-ip
@@ -295,7 +295,7 @@ steps:
295295
# command:
296296
# - --app=/app/features/fixtures/generated/react-native-navigation/new-arch/{{matrix}}/output/reactnative.ipa
297297
# - --farm=bb
298-
# - --device=IOS_15
298+
# - --device=IOS_17|IOS_18|IOS_26
299299
# - --fail-fast
300300
# - --no-tunnel
301301
# - --aws-public-ip

‎.buildkite/basic/react-native-ios-pipeline.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ steps:
4848
command:
4949
- --app=/app/features/fixtures/generated/new-arch/{{matrix}}/output/reactnative.ipa
5050
- --farm=bb
51-
- --device=IOS_15
51+
- --device=IOS_17|IOS_18|IOS_26
5252
- --fail-fast
5353
- --no-tunnel
5454
- --aws-public-ip

‎test/react-native/features/native-stack.feature‎

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -129,22 +129,23 @@ Scenario: Handled native promise rejection with native stacktrace
129129

130130
# the javascript part follows
131131
# On 0.74+ New Arch there is no JS stacktrace - see PLAT-12193
132-
And the event "exceptions.0.stacktrace.20.columnNumber" equals the version-dependent string:
132+
# We're check the method: asyncGeneratorStep
133+
And the event "exceptions.0.stacktrace.21.columnNumber" equals the version-dependent string:
133134
| arch | version | value |
134135
| new | 0.72 | @not_null |
135136
| new | default | @skip |
136137
| old | default | @not_null |
137-
And the event "exceptions.0.stacktrace.20.file" equals the version-dependent string:
138+
And the event "exceptions.0.stacktrace.21.file" equals the version-dependent string:
138139
| arch | version | value |
139140
| new | 0.72 | @not_null |
140141
| new | default | @skip |
141142
| old | default | @not_null |
142-
And the event "exceptions.0.stacktrace.20.lineNumber" equals the version-dependent string:
143+
And the event "exceptions.0.stacktrace.21.lineNumber" equals the version-dependent string:
143144
| arch | version | value |
144145
| new | 0.72 | @not_null |
145146
| new | default | @skip |
146147
| old | default | @not_null |
147-
And the event "exceptions.0.stacktrace.20.type" equals the version-dependent string:
148+
And the event "exceptions.0.stacktrace.21.type" equals the version-dependent string:
148149
| arch | version | value |
149150
| new | 0.72 | @null |
150151
| new | default | @skip |
@@ -173,22 +174,23 @@ Scenario: Unhandled native promise rejection with native stacktrace
173174

174175
# the javascript part follows
175176
# On 0.74+ New Arch there is no JS stacktrace - see PLAT-12193
176-
And the event "exceptions.0.stacktrace.20.columnNumber" equals the version-dependent string:
177+
# We're check the method: asyncGeneratorStep
178+
And the event "exceptions.0.stacktrace.21.columnNumber" equals the version-dependent string:
177179
| arch | version | value |
178180
| new | 0.72 | @not_null |
179181
| new | default | @skip |
180182
| old | default | @not_null |
181-
And the event "exceptions.0.stacktrace.20.file" equals the version-dependent string:
183+
And the event "exceptions.0.stacktrace.21.file" equals the version-dependent string:
182184
| arch | version | value |
183185
| new | 0.72 | @not_null |
184186
| new | default | @skip |
185187
| old | default | @not_null |
186-
And the event "exceptions.0.stacktrace.20.lineNumber" equals the version-dependent string:
188+
And the event "exceptions.0.stacktrace.21.lineNumber" equals the version-dependent string:
187189
| arch | version | value |
188190
| new | 0.72 | @not_null |
189191
| new | default | @skip |
190192
| old | default | @not_null |
191-
And the event "exceptions.0.stacktrace.20.type" equals the version-dependent string:
193+
And the event "exceptions.0.stacktrace.21.type" equals the version-dependent string:
192194
| arch | version | value |
193195
| new | 0.72 | @null |
194196
| new | default | @skip |

‎test/react-native/features/steps/react-native-steps.rb‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,11 @@ def wait_for_app_state(expected_state)
6363

6464
When('I relaunch the app after a crash') do
6565
state = wait_for_app_state :not_running
66-
# TODO: Really we should be using terminate_app/activate_app with the newer Appium client,
67-
# but for some reason they seem to make some scenarios flaky (presumably due to the
68-
# nature of how/when they close the app).
6966
manager = Maze::Api::Appium::AppManager.new
7067
if state != :not_running
71-
manager.close
72-
# manager.terminate
68+
manager.terminate
7369
end
74-
manager.launch
75-
# manager.activate
70+
manager.activate
7671
end
7772

7873
When('I clear any error dialogue') do

0 commit comments

Comments
 (0)