Merge pull request #32 from ziluvatar/fix-open-in-editor

bugthesystem · web-flow · commit 4075327d4a71 · 2016-07-18T16:17:09.000+03:00
Fix open link from editor
diff --git a/src/extension.js b/src/extension.js
@@ -104,10 +104,9 @@ function getGitHubLinkForRepo(cb) {
     getGitHubLink(cb);
 }
 
-function branchOnCallingContext(contexMenuParam, cb){
-    if (contexMenuParam !== undefined) {
-        fileFsPath = contexMenuParam._fsPath;
-        getGitHubLinkForFile(fileFsPath, cb);
+function branchOnCallingContext(args, cb){
+    if (args && args.fsPath) {
+        getGitHubLinkForFile(args.fsPath, cb);
     }
     else if (Window.activeTextEditor) {
         getGitHubLinkForCurrentEditorLine(cb);
@@ -117,12 +116,12 @@ function branchOnCallingContext(contexMenuParam, cb){
     }
 }
 
-function openInGitHub(contexMenuParam) {
-    branchOnCallingContext(contexMenuParam, open);
+function openInGitHub(args) {
+    branchOnCallingContext(args, open);
 }
 
-function copyGitHubLinkToClipboard(contexMenuParam) {
-    branchOnCallingContext(contexMenuParam, copy);
+function copyGitHubLinkToClipboard(args) {
+    branchOnCallingContext(args, copy);
 }
 
 function activate(context) {

Original file line number	Diff line number	Diff line change
`@@ -104,10 +104,9 @@ function getGitHubLinkForRepo(cb) {`
`104`	`104`	`getGitHubLink(cb);`
`105`	`105`	`}`
`106`	`106`
`107`		`-function branchOnCallingContext(contexMenuParam, cb){`
`108`		`- if (contexMenuParam !== undefined) {`
`109`		`- fileFsPath = contexMenuParam._fsPath;`
`110`		`- getGitHubLinkForFile(fileFsPath, cb);`
	`107`	`+function branchOnCallingContext(args, cb){`
	`108`	`+ if (args && args.fsPath) {`
	`109`	`+ getGitHubLinkForFile(args.fsPath, cb);`
`111`	`110`	`}`
`112`	`111`	`else if (Window.activeTextEditor) {`
`113`	`112`	`getGitHubLinkForCurrentEditorLine(cb);`
`@@ -117,12 +116,12 @@ function branchOnCallingContext(contexMenuParam, cb){`
`117`	`116`	`}`
`118`	`117`	`}`
`119`	`118`
`120`		`-function openInGitHub(contexMenuParam) {`
`121`		`- branchOnCallingContext(contexMenuParam, open);`
	`119`	`+function openInGitHub(args) {`
	`120`	`+ branchOnCallingContext(args, open);`
`122`	`121`	`}`
`123`	`122`
`124`		`-function copyGitHubLinkToClipboard(contexMenuParam) {`
`125`		`- branchOnCallingContext(contexMenuParam, copy);`
	`123`	`+function copyGitHubLinkToClipboard(args) {`
	`124`	`+ branchOnCallingContext(args, copy);`
`126`	`125`	`}`
`127`	`126`
`128`	`127`	`function activate(context) {`