Enable multi-line selection (#56)

Hi @suan Thanks 👍

Author: suan

src/extension.js

@@ -17,7 +17,7 @@ var findParentDir = require('find-parent-dir');
 
 const gitProvider = require('./gitProvider');
 
-function getGitProviderLink(cb, fileFsPath, line, pr) {
+function getGitProviderLink(cb, fileFsPath, lines, pr) {
     var cwd = workspace.rootPath;
     var repoDir = findParentDir.sync(workspace.rootPath, '.git') || cwd;
 
@@ -48,9 +48,14 @@ function getGitProviderLink(cb, fileFsPath, line, pr) {
                 cb(provider.prUrl(branch));
             }
             else {
-                cb(provider.webUrl(branch, subdir, line));
+                if (lines[0] == lines[1]) {
+                    cb(provider.webUrl(branch, subdir, lines[0]));
+                }
+                else {
+                    cb(provider.webUrl(branch, subdir, lines[0], lines[1]));
+                }
             }
-            
+
         });
     });
 }
@@ -61,15 +66,21 @@ function getGitProviderLinkForFile(fileFsPath, cb) {
     getGitProviderLink(cb, fileFsPath);
 }
 
-function getGitProviderLinkForCurrentEditorLine(cb) {
+function getGitProviderLinkForCurrentEditorLines(cb) {
     var editor = Window.activeTextEditor;
     if (editor) {
-        var lineIndex = editor.selection.active.line + 1;
         var fileFsPath = editor.document.uri.fsPath;
-        getGitProviderLink(cb, fileFsPath, lineIndex);
+        getGitProviderLink(cb, fileFsPath, getSelectedLines(editor));
     }
 }
 
+function getSelectedLines(editor) {
+    var anchorLineIndex = editor.selection.anchor.line + 1;
+    var activeLineIndex = editor.selection.active.line + 1;
+
+    return [anchorLineIndex, activeLineIndex].sort();
+}
+
 function getGitProviderLinkForRepo(cb) {
     getGitProviderLink(cb);
 }
@@ -87,7 +98,7 @@ function branchOnCallingContext(args, cb, pr) {
         getGitProviderLinkForFile(args.fsPath, cb);
     }
     else if (Window.activeTextEditor) {
-        getGitProviderLinkForCurrentEditorLine(cb);
+        getGitProviderLinkForCurrentEditorLines(cb);
     }
     else {
         getGitProviderLinkForRepo(cb);

src/gitProvider.js

@@ -19,30 +19,31 @@ class BaseProvider {
      * @param {string} branch
      * @param {string} filePath The file path relative to repository root, beginning with '/'.
      * @param {number} line
+     * @param {number} endLine The last line in a multi-line selection
      * @return {string} The URL to be opened with the browser.
      */
-    webUrl(branch, filePath, line) {
+    webUrl(branch, filePath, line, endLine) {
         return '';
     }
     prUrl(branch) {
         return '';
-    }    
+    }
 }
 
 class GitHub extends BaseProvider {
-    webUrl(branch, filePath, line) {
+    webUrl(branch, filePath, line, endLine) {
         if (filePath) {
-            return `${this.baseUrl}/blob/${branch}${filePath}` + (line ? '#L' + line : '');
+            return `${this.baseUrl}/blob/${branch}${filePath}` + (line ? '#L' + line : '') + (endLine ? '-L' + endLine : '');
         }
         return `${this.baseUrl}/tree/${branch}`;
     }
     prUrl(branch){
         return `${this.baseUrl}/pull/new/${branch}`;
-    }    
+    }
 }
 
 class Bitbucket extends BaseProvider {
-    webUrl(branch, filePath, line) {
+    webUrl(branch, filePath, line, endLine) {
         return `${this.baseUrl}/src/${branch}` + (filePath ? `${filePath}` : '') + (line ? `#cl-${line}` : '');
     }
     prUrl(branch){
@@ -58,7 +59,7 @@ class VisualStudio extends BaseProvider {
         return `https://${this.gitUrl.resource}${this.gitUrl.pathname}`.replace(/\.git/, '');
     }
 
-    webUrl(branch, filePath, line) {
+    webUrl(branch, filePath, line, endLine) {
         let query = {
             version: `GB${branch}`,
         };