add tests

Author: imanushin

gradle-plugin-utils/api/gradle-plugin-utils.api

@@ -8,7 +8,6 @@ public final class build/extensions/oss/gradle/pluginutils/DurationUtilsKt {
 }
 
 public final class build/extensions/oss/gradle/pluginutils/ExtensionUtilsKt {
-	public static final fun extension (Ljava/lang/Object;Ljava/lang/String;Ljava/lang/Class;)Ljava/lang/Object;
 	public static final fun requiredExtension (Ljava/lang/Object;Ljava/lang/String;Ljava/lang/Class;)Ljava/lang/Object;
 }
 

gradle-plugin-utils/src/main/kotlin/build/extensions/oss/gradle/pluginutils/ExtensionUtils.kt

@@ -2,35 +2,6 @@ package build.extensions.oss.gradle.pluginutils
 
 import org.gradle.api.plugins.ExtensionAware
 
-/**
- * Gets the extension of the given name if it exists.
- *
- * Will return `null` if the receiver is not [ExtensionAware].
- *
- * @receiver the object containing extensions
- * @param name the extension name
- * @return the extension, or `null` if it does not exist
- */
-inline fun <reified T : Any> Any.extension(name: String): T? {
-    @Suppress("UNCHECKED_CAST")
-    return extension(name, T::class.java)
-}
-
-/**
- * Gets the extension of the given name if it exists.
- *
- * Will return `null` if the receiver is not [ExtensionAware].
- *
- * @receiver the object containing extensions
- * @param name the extension name
- * @return the extension, or `null` if it does not exist
- */
-fun <T : Any> Any.extension(name: String, clazz: Class<T>): T? {
-    val resultCandidate = (this as? ExtensionAware)?.extensions?.findByName(name)
-
-    return clazz.cast(resultCandidate)
-}
-
 /**
  * Gets the extension of the given name if it exists.
  *
@@ -61,19 +32,6 @@ fun <T : Any> Any.requiredExtension(name: String, clazz: Class<T>): T {
 }
 
 
-/**
- * Gets the extension of the given type if it exists.
- *
- * Will return `null` if the receiver is not [ExtensionAware].
- *
- * @receiver the object containing extensions
- * @param <T> the extension type
- * @return the extension, or `null` if it does not exist
- */
-inline fun <reified T : Any> Any.extension(): T? =
-    (this as? ExtensionAware)?.extensions?.findByType(typeOf<T>())
-
-
 /**
  * Gets the extension of the given type, throwing an exception if it does not exist.
  *

gradle-plugin-utils/src/test/kotlin/build/extensions/oss/gradle/pluginutils/ExtensionUtilsTest.kt

@@ -0,0 +1,54 @@
+package build.extensions.oss.gradle.pluginutils
+
+import io.kotest.assertions.throwables.shouldThrow
+import io.kotest.matchers.should
+import io.kotest.matchers.string.haveSubstring
+import io.kotest.matchers.types.beTheSameInstanceAs
+import io.mockk.every
+import io.mockk.mockk
+import org.gradle.api.plugins.ExtensionAware
+import org.gradle.api.plugins.ExtensionContainer
+import org.junit.jupiter.api.Test
+
+class ExtensionUtilsTest {
+
+    /**
+     * Ensure we don't do strict cast internally
+     */
+    @Test
+    fun shouldReturnNullForNonExtensionAware() {
+        val expectedMessages = listOf(
+            "org.gradle.api.plugins.ExtensionAware",
+            "cannot be cast to"
+        )
+        val somethingWhichIsNotExtension = "131223"
+
+        val exception = shouldThrow<Exception> { somethingWhichIsNotExtension.requiredExtension<String>("abc") }
+
+        expectedMessages.forEach { message ->
+            exception.message should haveSubstring(message)
+        }
+    }
+
+    /**
+     * Check if we propagate the call to API below.
+     * Basically, we ensure that our intermediate code doesn't have something new.
+     */
+    @Test
+    fun shouldPropagateLookupCall() {
+        val extensionName = "abc"
+        // some object which will play a role of extension
+        val extensionToResolve = Runnable {}
+
+        val extensionsContainer = mockk<ExtensionContainer> {
+            every { getByName(extensionName) } returns extensionToResolve
+        }
+        val extensionAware = mockk<ExtensionAware> {
+            every { extensions } returns extensionsContainer
+        }
+
+        val exception = extensionAware.requiredExtension<Runnable>(extensionName)
+
+        exception should beTheSameInstanceAs(extensionToResolve)
+    }
+}