fix: early exit in scripts due to post increment ((var++))

Author: punkch

scripts/base-install.sh

@@ -217,7 +217,7 @@ download_all_files() {
             [[ -d "$dir_path" ]] || mkdir -p "$dir_path"
 
             if download_file "$file_path" "$dest_file"; then
-                ((file_count++))
+                ((file_count++)) || true
                 print_verbose "  Downloaded: ${file_path}"
             else
                 print_verbose "  Failed to download: ${file_path}"
@@ -448,7 +448,7 @@ full_update() {
                 local dir_path=$(dirname "$dest_file")
                 [[ -d "$dir_path" ]] || mkdir -p "$dir_path"
                 if download_file "$file_path" "$dest_file"; then
-                    ((file_count++))
+                    ((file_count++)) || true
                     print_verbose "  Downloaded: ${file_path}"
                 fi
             fi
@@ -469,7 +469,7 @@ full_update() {
                 local dir_path=$(dirname "$dest_file")
                 [[ -d "$dir_path" ]] || mkdir -p "$dir_path"
                 if download_file "$file_path" "$dest_file"; then
-                    ((file_count++))
+                    ((file_count++)) || true
                     print_verbose "  Downloaded: ${file_path}"
                 fi
             fi
@@ -532,7 +532,7 @@ overwrite_profile() {
                 [[ -d "$dir_path" ]] || mkdir -p "$dir_path"
 
                 if download_file "$file_path" "$dest_file"; then
-                    ((file_count++))
+                    ((file_count++)) || true
                     print_verbose "  Downloaded: ${file_path}"
                 fi
             fi
@@ -563,7 +563,7 @@ overwrite_scripts() {
                 [[ -d "$dir_path" ]] || mkdir -p "$dir_path"
 
                 if download_file "$file_path" "$dest_file"; then
-                    ((file_count++))
+                    ((file_count++)) || true
                     print_verbose "  Downloaded: ${file_path}"
                 fi
             fi

scripts/common-functions.sh

@@ -515,7 +515,7 @@ process_conditionals() {
                 should_include=false
             fi
 
-            ((nesting_level++))
+            ((nesting_level++)) || true
             continue
         fi
 
@@ -550,7 +550,7 @@ process_conditionals() {
                 should_include=false
             fi
 
-            ((nesting_level++))
+            ((nesting_level++)) || true
             continue
         fi
 

scripts/create-profile.sh

@@ -130,7 +130,7 @@ select_inheritance() {
         local index=2
         for profile in "${profiles[@]}"; do
             echo "  $index) $profile"
-            ((index++))
+            ((index++)) || true
         done
 
         echo ""
@@ -194,7 +194,7 @@ select_copy_source() {
         local index=2
         for profile in "${profiles[@]}"; do
             echo "  $index) $profile"
-            ((index++))
+            ((index++)) || true
         done
 
         echo ""