Merge pull request #67 from buildingu/feat-add-reviewer-functionality

Update: app functionality

Author: gbudjeakp

Controllers/feedbackController.js

@@ -73,37 +73,17 @@ const submitFeedBack = async (req, res) => {
 /*This retrieves every single feedback (only requests that are not marked as complete requests made by the interns
  */
 const getAllFeedBackRequestsForms = async (req, res) => {
-  const { authToken } = req.cookies;
-  const { id, username } = jwt.verify(authToken, process.env.JWT_SECRET);
   try {
-    const isMentor = await User.findOne({
-      where: {
-        id: id,
-        mentor: true,
-      },
-    });
-    if (isMentor) {
-      const feedBackrequests = await FeedbackRequest.findAll({
-        where: {
-          status: {
-            [Op.not]: true,
-          },
-        },
-      });
-      res.status(200).json({ data: feedBackrequests });
-    }
-    //Not sure why this was added. Might not be useful. Will revisit to make sure it's needed.
-    if (!isMentor) {
+
       const feedBackrequests = await FeedbackRequest.findAll({
         where: {
-          studentName: username,
           status: {
             [Op.not]: true,
           },
         },
       });
       res.status(200).json({ data: feedBackrequests });
-    }
+
   } catch (err) {
     res.status(500).json({ error: "Internal Server Error" });
     logger.error(`Server Error`, {error: JSON.stringify(err)})
@@ -184,13 +164,49 @@ const flockNotification = async (req, res) => {
   }
 };
 
-//////////////////////////////////////////
-/* Code below here are basically controller functions 
-for the Code leads or mentor endpoints 
-*/
-///////////////////////////////////////////////
 
-/*This controller allows the Code leads to add feedbacks to the feedback requests made  by the interns */
+/*This controller allows users to assign feedback requests to themselves
+for 
+ */
+const assignFeedBack = async (req, res) => {
+  try {
+    const { feedbackrequestId } = req.params;
+    const { authToken } = req.cookies;
+    const { id, username } = jwt.verify(authToken, process.env.JWT_SECRET);
+
+
+    // Grab the user information based on the id for updates of the request form.
+    const userDetail = await User.findOne({
+      where: username,
+      where: {id: id}
+    })
+
+    // Find the specific feedback request record based on feedbackrequestId
+    const feedbackRecord = await FeedbackRequest.findOne({
+      where: { id: feedbackrequestId },
+    });
+
+    if (!feedbackRecord) {
+      logger.error(`Feedback record not found`, {log: JSON.stringify(feedbackRecord)})
+      return res.status(404).json({ msg: "Feedback record not found" }); 
+    }
+
+    feedbackRecord.isAssigned = true;
+    feedbackRecord.whoisAssigned = userDetail.fName;
+    await feedbackRecord.save();
+
+    logger.info(`Feedback assigned to mentor`, {log: JSON.stringify(feedbackRecord)})
+    res.json({ msg: "Feedback assigned to mentor", data:  feedbackRecord });
+  } catch (err) {
+    logger.error(`An error occurred while updating feedback`, {log: JSON.stringify(err)})
+    res
+      .status(500)
+      .json({ error: "An error occurred while updating feedback" });
+  }
+};
+
+
+/*This controller allows users to add feedbacks to the feedback requests in the queue */
 const addFeedBack = async (req, res) => {
   try {
     const { feedback } = req.body;
@@ -204,18 +220,6 @@ const addFeedBack = async (req, res) => {
       return res.status(400).json(errors);
     }
 
-    // Check if the user is a mentor
-    const isMentor = await User.findOne({
-      where: {
-        id: id,
-        mentor: true,
-      },
-    });
-
-    if (!isMentor) {
-      logger.error(`Unauthorized user`, {log: JSON.stringify(isMentor)})
-      return res.status(401).json({ msg: "Unauthorized user" });
-    }
 
     // Find the specific feedback request record based on feedbackrequestId
     const feedbackRequest = await FeedbackRequest.findOne({
@@ -252,51 +256,12 @@ const addFeedBack = async (req, res) => {
   }
 };
 
-/*This controller allows the Code leads to assign feedback requests to themselves
- */
-const assignFeedBackToMentor = async (req, res) => {
-  try {
-    const { feedbackrequestId } = req.params;
-    const { authToken } = req.cookies;
-    const { id } = jwt.verify(authToken, process.env.JWT_SECRET);
-
-    // Check if the user is a mentor
-    const isMentor = await User.findOne({
-      where: {
-        id: id,
-        mentor: true,
-      },
-    });
-
-    if (!isMentor) {
-      logger.error(`Unauthorized user`, {log: JSON.stringify(isMentor)})
-      return res.status(401).json({ msg: "Unauthorized user" });
-    }
-
-    // Find the specific feedback request record based on feedbackrequestId
-    const feedbackRecord = await FeedbackRequest.findOne({
-      where: { id: feedbackrequestId },
-    });
-
-    if (!feedbackRecord) {
-      logger.error(`Feedback record not found`, {log: JSON.stringify(feedbackRecord)})
-      return res.status(404).json({ msg: "Feedback record not found" }); 
-    }
-
-    feedbackRecord.isAssigned = true;
-    feedbackRecord.mentorId = isMentor.mentorId;
-    feedbackRecord.whoisAssigned = isMentor.fName;
-    await feedbackRecord.save();
 
-    logger.info(`Feedback assigned to mentor`, {log: JSON.stringify(feedbackRecord)})
-    res.json({ msg: "Feedback assigned to mentor", data:  feedbackRecord });
-  } catch (err) {
-    logger.error(`An error occurred while updating feedback`, {log: JSON.stringify(err)})
-    res
-      .status(500)
-      .json({ error: "An error occurred while updating feedback" });
-  }
-};
+//////////////////////////////////////////
+/* Code below here are basically controller functions 
+for the Code leads or mentor endpoints 
+*/
+///////////////////////////////////////////////
 
 /*This controller retrieves all the assigned Feedback Requests
 of the code lead logged in.
@@ -422,7 +387,7 @@ module.exports = {
   submitFeedBack,
   getAllFeedBackRequestsForms,
   getUserFeedBackRequestForms,
-  assignFeedBackToMentor,
+  assignFeedBack,
   addFeedBack,
   getAssignedFeedBacks,
   getMentorFeedback,

Controllers/userController.js

@@ -8,7 +8,7 @@ const Users = db.User;
 const ExerciseInfo = db.ExerciseInfo;
 const FeedbackRequest = db.FeedbackRequest;
 const Feedbacks = db.Feedbacks;
-const Mentors = db.Mentors;
+const Mentors = require("../admin.json");
 const loginValidator = require("../utility/inputValidator/loginValidator");
 const registerValidator = require("../utility/inputValidator/registerValidator");
 const logger = require("../utility/logger/logger");
@@ -18,8 +18,9 @@ const registerUser = async (req, res) => {
   const { fName, userName, password } = req.body;
   const { errors, validationCheck } = registerValidator(req.body);
   const isUserExist = await Users.findOne({ where: { username: userName } });
-  const isMentorEmail = await Mentors.findOne({ where: { email: userName } });
-  const isUserMentor = !!isMentorEmail;  
+
+  //Check if the user should be a mentor based on the email
+  const isMentor = Mentors.Mentors.include(userName);
   const { v4: uuidv4 } = require("uuid");
 
   // This checks that the inputs entered meet some criteria
@@ -48,8 +49,8 @@ const registerUser = async (req, res) => {
       fName: fName,
       username: userName,
       password: hashedPassword,
-      mentor: isUserMentor,
-      mentorId: isUserMentor ? uuidv4() : null,
+      mentor: isMentor,
+      mentorId: isMentor ? uuidv4() : null,
     };
 
     await Users.create(userData);

Models/Mentors.js

@@ -12,7 +12,6 @@ const FeedbackRequest = require("./Feedbackrequest")(sequelize, DataTypes);
 const Feedbacks = require("./Feedbacks")(sequelize, DataTypes);
 const Otptoken = require("./Otptoken")(sequelize, DataTypes);
 const ExerciseInfo = require("./ExerciseInfo")(sequelize, DataTypes);
-const Mentors = require("./Mentors")(sequelize, DataTypes);
 
 
 //This was poorly desgined. Should spent more time fixing this
@@ -58,5 +57,4 @@ module.exports = {
   Feedbacks,
   Otptoken,
   ExerciseInfo,
-  Mentors,
 };

Models/index.js

@@ -6,7 +6,7 @@ const feedbackController = require('../Controllers/feedbackController')
 
 router.post("/submitfeedback", auth, rateLimiter, feedbackController.submitFeedBack);
 
-router.post("/assignFeedBackToMentor/:feedbackrequestId", auth, rateLimiter,feedbackController.assignFeedBackToMentor);
+router.post("/assignFeedBack/:feedbackrequestId", auth, rateLimiter,feedbackController.assignFeedBack);
 
 router.post("/addFeedBack/:feedbackrequestId", auth, rateLimiter, feedbackController.addFeedBack);
 

Routes/Feedback.js

@@ -0,0 +1,9 @@
+{
+    "Mentors":[
+     "tamara@building-u.com",
+     "kjgarbos@gmail.com",
+     "gbudjeakp@gmail.com",
+     "andrewsh190@gmail.com",
+     "siddhanth.subramanian99@gmail.com"
+    ]
+}

admin.json

@@ -1,6 +1,6 @@
 {
   "name": "building-u-feedback-api",
-  "version": "v3.0.0",
+  "version": "v4.0.0",
   "description": "This is for the server api that serves the app",
   "main": "index.js",
   "scripts": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "building-u-feedback",
-  "version": "v3.0.0",
+  "version": "v4.0.0",
   "homepage": "https://buildingu.github.io/Building-u-feedback",
   "type": "module",
   "scripts": {

views/package.json

@@ -14,6 +14,7 @@ function CreatedRequests(props) {
   return (
     <div>
       <FeedbackCard
+        notifyMentor={true}
         showViewFeedback={true}
         data={internFeedbackRequests}
         pageTitle="MY FEEDBACK REQUESTS"

views/src/Pages/CreatedRequests.jsx

@@ -15,6 +15,7 @@ function FeedbackQueue(props) {
     <div>
       <FeedbackCard
         isAssign={true}
+        showAddFeedback={true}
         data={feedbackData}
         pageTitle="FEEDBACK QUEUE"
         user={props.user}