Skip to content

Commit d1a5ec7

Browse files
authored
Merge pull request #35 from buildingu/chore-fix-feedbackrequestform
Patch-fix-Feedback-Request-Form
2 parents 15d362f + e4361ec commit d1a5ec7

File tree

5 files changed

+7
-17
lines changed

5 files changed

+7
-17
lines changed

Controllers/feedbackController.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ const submitFeedBack = async (req, res) => {
6060
await exerciseInfo.create(add_User_To_ExerciseInfo_Table);
6161
await FeedbackRequest.create(feedBackRequestData);
6262
studentNotification(feedBackRequestData);
63-
6463
}
6564

6665
res.status(200).json({ data: feedBackRequestData });

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "building-u-feedback-api",
3-
"version": "v0.4.2-alpha",
3+
"version": "v0.4.4-alpha",
44
"description": "This is for the server api that serves the app",
55
"main": "index.js",
66
"scripts": {

views/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "building-u-feedback",
3-
"version": "v0.2.1-alpha",
3+
"version": "v0.2.2-alpha",
44
"homepage": "https://buildingu.github.io/Building-u-feedback",
55
"type": "module",
66
"scripts": {

views/src/Pages/FeedbackrequestForm.jsx

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,8 @@ function FeedbackRequestForm() {
6060
const [opened, { open, close }] = useDisclosure(false);
6161

6262
const form = useForm({
63-
initialValues: { name: "", topicOfLearningSession: null, codeLink: "" },
63+
initialValues: { topicOfLearningSession: null, codeLink: "" },
6464
validate: {
65-
name: (value) =>
66-
value.length < 3 ? "Name must have at least 3 letters" : null,
6765
topicOfLearningSession: (value) =>
6866
topics.some((item) => value?.includes(item))
6967
? null
@@ -74,10 +72,11 @@ function FeedbackRequestForm() {
7472
const handleSubmitRequest = () => {
7573
dispatch(createFeedbackRequest(form.values));
7674
dispatch(fetchFeedbackRequests());
75+
7776
if (loading === "succeeded"){
7877
open()
7978
}
80-
form.setValues({ name: "", topicOfLearningSession: null, codeLink: "" });
79+
form.setValues({ topicOfLearningSession: null, codeLink: "" });
8180
};
8281

8382
return (
@@ -100,14 +99,6 @@ function FeedbackRequestForm() {
10099
Request Feedback
101100
</Text>
102101
<div style={formStyle}>
103-
<TextInput
104-
variant="filled"
105-
style={inputStyle}
106-
id="internName"
107-
label="Intern Name"
108-
placeholder="Enter intern's name"
109-
{...form.getInputProps("name")}
110-
/>
111102
<Select
112103
label="Topic of Learning Session"
113104
placeholder="Select the topic of the learning session"

views/src/features/Feedbacks/feedbackSlice.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ const createAsyncThunkWithJwt = (type, url, method = "get") =>
4141

4242
const createFeedbackRequest = createAsyncThunkWithJwt(
4343
"feedback/create",
44-
`${baseUrl}/api/feedback/submitfeedback",
45-
"post`
44+
`${baseUrl}/api/feedback/submitfeedback`,
45+
"post"
4646
);
4747

4848
const addFeedback = createAsyncThunkWithJwt(

0 commit comments

Comments
 (0)