Skip to content

Commit 0c69a9c

Browse files
authored
Escape HTML in test output
Fixes #39
1 parent 48cdceb commit 0c69a9c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ruby/bin/annotate

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
require 'rexml/document'
44
require 'rexml/element'
5+
require 'cgi/util'
56

67
# Reads a list of junit files and returns a nice Buildkite build annotation on
78
# STDOUT that summarizes any failures.
@@ -78,7 +79,7 @@ failures.each do |failure|
7879
puts "<details>"
7980
puts "<summary><code>#{failure.name} in #{failure.failed_test}</code></summary>\n\n"
8081
if failure.body
81-
puts "<pre><code>#{failure.body.chomp.strip}</code></pre>\n\n"
82+
puts "<pre><code>#{CGI.escapeHTML(failure.body.chomp.strip)}</code></pre>\n\n"
8283
end
8384
if failure.job
8485
puts "in <a href=\"##{failure.job}\">Job ##{failure.job}</a>"

0 commit comments

Comments
 (0)