Skip to content

Commit 132401a

Browse files
committed
Renamed option
1 parent 1ce7951 commit 132401a

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

hooks/command

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ docker \
5151
--env "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_JOB_UUID_FILE_PATTERN=${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_JOB_UUID_FILE_PATTERN:-}" \
5252
--env "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_FAILURE_FORMAT=${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_FAILURE_FORMAT:-}" \
5353
--env "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_REPORT_SLOWEST=${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_REPORT_SLOWEST:-}" \
54-
--env "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_SKIPPED_FORMAT=${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_SKIPPED_FORMAT:-none}" \
54+
--env "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_REPORT_SKIPPED=${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_REPORT_SKIPPED:-}" \
5555
"${RUBY_IMAGE}" ruby /src/bin/annotate /junits \
5656
> "$annotation_path"
5757

ruby/bin/annotate

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ failure_format = ENV['BUILDKITE_PLUGIN_JUNIT_ANNOTATE_FAILURE_FORMAT']
1818
failure_format = 'classname' if !failure_format || failure_format.empty?
1919

2020
report_slowest = ENV['BUILDKITE_PLUGIN_JUNIT_ANNOTATE_REPORT_SLOWEST'].to_i
21+
report_skipped = ENV['BUILDKITE_PLUGIN_JUNIT_ANNOTATE_REPORT_SKIPPED'] == 'true'
2122

2223
class Failure < Struct.new(:name, :unit_name, :body, :job, :message)
2324
end
@@ -115,7 +116,7 @@ if report_slowest > 0
115116
puts "</details>"
116117
end
117118

118-
if ENV.fetch('BUILDKITE_PLUGIN_JUNIT_ANNOTATE_SKIPPED_FORMAT', 'none') != 'none'
119+
if report_skipped
119120
STDERR.puts "Reporting skipped tests"
120121
puts ""
121122
puts "<details>"

ruby/tests/annotate_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,7 +602,7 @@
602602
end
603603

604604
it "can report skipped tests" do
605-
stdout, stderr, status = Open3.capture3("env", "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_SKIPPED_FORMAT=classname", "#{__dir__}/../bin/annotate", "#{__dir__}/skipped-test/")
605+
stdout, stderr, status = Open3.capture3("env", "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_REPORT_SKIPPED=true", "#{__dir__}/../bin/annotate", "#{__dir__}/skipped-test/")
606606

607607
assert_equal stderr, <<~OUTPUT
608608
Parsing junit.xml

0 commit comments

Comments
 (0)