Fail more gracefully if mandatory option is not correctly set

toote · toote · commit afecb0731549 · 2022-10-14T21:26:51.000-03:00
diff --git a/hooks/command b/hooks/command
@@ -2,6 +2,11 @@
 
 set -euo pipefail
 
+if [[ -z "${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS:-}" ]]; then
+  echo "🚨 Missing artifacts configuration for the plugin"
+  exit 1
+fi
+
 PLUGIN_DIR="$(cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd)/.."
 MAX_SIZE=1024 # in KB
 
diff --git a/tests/command.bats b/tests/command.bats
@@ -148,7 +148,8 @@ export annotation_input="tests/tmp/annotation.input"
 
   assert_failure
 
-  assert_output --partial "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS: unbound variable"
+  assert_output --partial "Missing artifacts configuration for the plugin"
+  refute_output --partial ":junit:"
 }
 
 @test "fails if the annotation is larger than 1MB" {

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,8 @@ export annotation_input="tests/tmp/annotation.input"`
`148`	`148`
`149`	`149`	`assert_failure`
`150`	`150`
`151`		`- assert_output --partial "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS: unbound variable"`
	`151`	`+ assert_output --partial "Missing artifacts configuration for the plugin"`
	`152`	`+ refute_output --partial ":junit:"`
`152`	`153`	`}`
`153`	`154`
`154`	`155`	`@test "fails if the annotation is larger than 1MB" {`